fix(core): canonicalize default MapLibre glyph URLs - #4490
Draft
fallenmi wants to merge 1 commit into
Draft
Conversation
Generated-by: OpenAI Codex (GPT-5)
|
Confirmed this fixes josxha/flutter-maplibre#535: I reproduced the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{path}grammar used by URL canonicalization{fontstack}/{range}in the canonicalmaplibre://fonts/...URLRoot cause
createTokenMapexpands only its generic URL placeholders. The default MapLibre glyph template contained{fontstack},{start}, and{end}, so those braces reachedstd::regexand could raisestd::regex_errorwhile an offline pack was being prepared.This change is intentionally scoped to the default MapLibre/demotiles configuration. It does not broaden the generic template parser for arbitrary custom glyph templates.
Fixes #4403.
Validation
MapLibre.CanonicalURLregression throwsstd::regex_errorbefore the source changeTileServerOptionsURL testsgit diff --checkThe full project suite was not completed locally; remote CI is pending.
AI assistance disclosure
OpenAI Codex (GPT-5) assisted with investigation, test drafting, implementation, validation, and this draft description. The contributor must personally review every changed line and approve or rewrite this description before marking the PR ready for review.