fix: ignore empty polygon parts in MultiPolygon - #195
Open
spokodev wants to merge 1 commit into
Open
Conversation
A MultiPolygon whose coordinates contain an empty polygon (for example [[], [ring]]) threw a TypeError while building the feature bounding box, because createFeature reads polygon[0] on the empty part. A single such part in an otherwise valid FeatureCollection aborted the whole tiling. Skip empty polygon parts during conversion, matching the guard already present in clip.js, so the valid parts still get tiled.
Member
|
geojson-vt is in the middle of a big rewrite (see #191), so I'll hold on merging any fixes to the project until the overhaul is merged. This will likely need to be applied from scratch to the new code if still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
MultiPolygonwhosecoordinatescontain an empty polygon part (for example[[], [ring]]) throwsTypeError: Cannot read properties of undefined (reading 'length')while building the feature bounding box, becausecreateFeaturereadspolygon[0]on the empty part. A single such part in an otherwise validFeatureCollectionaborts the whole index build, so no tiles are produced.This skips empty polygon parts during conversion, matching the
if (newPolygon.length)guard already used inclip.js, so the valid parts still get tiled. Adds a test that fails onmainwith theTypeErrorand passes with the fix.