Skip to content

Extract postcode districts & fetch districts instead when bbox is too big#8

Merged
rm-hull merged 4 commits into
mainfrom
feat/district-polygons
Jun 26, 2025
Merged

Extract postcode districts & fetch districts instead when bbox is too big#8
rm-hull merged 4 commits into
mainfrom
feat/district-polygons

Conversation

@rm-hull

@rm-hull rm-hull commented Jun 26, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rm-hull, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the data extraction utility by introducing support for processing and storing GeoJSON data related to postcode districts, alongside the existing postcode units. This change is foundational for enabling broader search capabilities, particularly when dealing with large geographical areas, as suggested by the PR title's mention of 'searching when bbox is too big'. The modifications generalize the data handling pipeline to accommodate different types of geographical data.

Highlights

  • Support for Postcode Districts: The data extraction utility (cmd/extract_data.go) has been updated to explicitly handle and store GeoJSON data for postcode districts. This includes creating dedicated directories (./data/postcodes/districts) for these new data types.
  • Generalized Data Processing Logic: The core logic for identifying and reprocessing GeoJSON features from the input tarball has been refactored. A new extractFileType function now dynamically determines if a file represents a 'unit' or 'district' and identifies the relevant property name (e.g., 'postcodes' or 'district') within the GeoJSON feature. The reprocessFeatureCollection function was updated to leverage this, making it more generic for handling both data types.
  • Dynamic Output File Structure: Processed and compressed GeoJSON files are now saved into type-specific subdirectories. For example, postcode units go into ./data/postcodes/units/ and postcode districts go into ./data/postcodes/districts/, ensuring better organization of the extracted data.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Jun 26, 2025

Copy link
Copy Markdown
TestsPassed ❌️SkippedFailed
JUnit Test Report0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes introduce the ability to extract postcode districts in addition to postcode units, and refactors the code to handle both types of data. The changes also allow the program to continue processing even if some files fail to extract or compress. The review focuses on error handling and improving the robustness of the extraction process.

Comment thread cmd/extract_data.go
Comment thread cmd/extract_data.go
Comment thread cmd/extract_data.go Outdated
@rm-hull rm-hull changed the title Extract postcode districts & allow searching when bbox is too big Extract postcode districts & fetch districts instead when bbox is too big Jun 26, 2025
@rm-hull
rm-hull merged commit ab5b666 into main Jun 26, 2025
3 checks passed
@rm-hull
rm-hull deleted the feat/district-polygons branch June 26, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant