Polygon search

[rm-hull]

No description provided.

[github-actions]

	Tests	Passed ❌️	Skipped	Failed
JUnit Test Report	0 ran	0 passed	0 skipped	0 failed

Test	Result
No test annotations available

• View JUnit Test Report

[coveralls]

Pull Request Test Coverage Report for Build 15871888841

Details

• 0 of 86 (0.0%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage remained the same at 0.0%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
main.go	0	2	0.0%
spatial-index/codepoint.go	0	13	0.0%
routes/search.go	0	71	0.0%

Files with Coverage Reduction	New Missed Lines	%
spatial-index/codepoint.go	1	0.0%

Totals
Change from base Build 15853203916:	0.0%
Covered Lines:	0
Relevant Lines:	413

---

💛 - Coveralls

[gemini-code-assist]

Code Review

This pull request introduces a new polygon search feature, including a new API endpoint and refactoring of the spatial index search logic. Review comments address potential issues in the new PolygonSearch handler, opportunities to improve the handler's resilience and readability, and a breaking change due to endpoint renaming.

[rm-hull]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request implements a new API endpoint for searching postcode polygons based on a bounding box. It introduces the ability to load polygon data from compressed GeoJSON files, leveraging a spatial index to efficiently retrieve relevant data. The changes also include refactoring the spatial index search to use an iterator, and adding necessary dependencies for GeoJSON handling and bzip2 decompression.

Highlights

• New API Endpoint: Introduces a new /v1/postcode/polygons endpoint that searches for postcode polygons within a given bounding box.
• Polygon Data Loading: Adds functionality to load postcode polygon data from compressed GeoJSON files (bzip2) stored locally.
• Spatial Indexing: Modifies the spatial index search to use an iterator pattern for more efficient data retrieval.
• Dependency Updates: Adds jsoniter, dsnet/compress/bzip2, and paulmach/orb/geojson as new dependencies.

Changelog

• Dockerfile
  • Added the jsoniter tag to the go build command.
• main.go
  • Renamed the /v1/postcode/codepoint endpoint to /v1/postcode/codepoints.
  • Added a new route /v1/postcode/polygons that calls the PolygonSearch function.
• routes/search.go
  • Added imports for os, github.com/dsnet/compress/bzip2, jsoniter, and github.com/paulmach/orb/geojson.
  • Implemented the PolygonSearch function to handle polygon searches based on a bounding box.
  • Implemented the loadFromFile function to load GeoJSON feature collections from bzip2 compressed files.
  • The PolygonSearch function extracts the bounding box from the query parameters, searches the spatial index for relevant postcodes, loads the corresponding GeoJSON polygons, and returns a FeatureCollection containing the matching polygons.
• spatial-index/codepoint.go
  • Refactored the Search function to use SearchIter internally.
  • Introduced the SearchIter function to allow iterating over search results without collecting all results into a slice at once.
  • The original Search function now returns an error if an error occurs during the spatial search.

Activity

• The pull request was created to add polygon search functionality.
• JUnit tests reported no tests ran.
• Coveralls reported 0.0% coverage for the changed lines.
• gemini-code-assist[bot] left review comments pointing out potential issues such as sending the HTTP response within a loop, error handling in loadFromFile, nested if statements, and the breaking change of renaming the /v1/postcode/codepoint endpoint.