Skip to content

Inflate the bound box to include polygons whos centroids might be just outside the current bounds #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rm-hull merged 2 commits into from
Jun 28, 2025
Merged

Inflate the bound box to include polygons whos centroids might be just outside the current bounds #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e199db
Inflate the bound box to include polygons whos centroids might be jus…
rm-hull Jun 28, 2025
f940d46
Address PR comments
rm-hull Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions routes/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import (
"github.com/paulmach/orb/geojson"
)

const UNITS_BOUNDS_EXPANSION = 100

type SearchResponse struct {
Results []spatialindex.CodePoint `json:"results"`
Attribution []string `json:"attribution"`
Expand Down Expand Up @@ -62,6 +64,10 @@ func PolygonSearch(spatialIndex *spatialindex.SpatialIndex, cache *memoize.Memoi
tooBig := isTooBig(bbox)
target := map[bool]string{true: "districts", false: "units"}[tooBig]

if target == "units" {
expandBounds(&bbox, UNITS_BOUNDS_EXPANSION)
}

requested := make(map[string]struct{}, 100)
districts := make(map[string]struct{}, 20)

Expand Down Expand Up @@ -110,6 +116,14 @@ func PolygonSearch(spatialIndex *spatialindex.SpatialIndex, cache *memoize.Memoi
}
}

func expandBounds(bbox *[]uint32, extendBy uint32) {
b := *bbox
b[0] -= extendBy // min_easting
b[1] -= extendBy // min_northing
b[2] += extendBy // max_easting
b[3] += extendBy // max_northing
}

func parseBBox(bboxStr string) ([]uint32, error) {
bboxParts := strings.Split(bboxStr, ",")
if len(bboxParts) != 4 {
Expand Down