ci: allow the "!" breaking-change marker in the commit-msg hook - #4
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The
commit-msgconventional-commit check matched<type>(scope): <desc>but had no slot for the!that Conventional Commits uses to flag a breaking change. Subjects likerefactor(scope)!: ...were rejected locally, forcing the breaking marker to be smuggled in via the squash-merge PR title instead of living in the commit itself.Fix
Add an optional
!?between the (optional) scope and the colon, and update the error hint to show it:Verification
refactor(atomic)!: breakingfeat!: breaking no scopedocs(adr): normalnope: bad typeOne-line change to
lefthook.yml; no behavior change for existing non-breaking subjects.Ported from manuelmauro/algonaut#320.