Fix: openfoodfacts: handle product with null name. - #43
Open
GoodOldJack12 wants to merge 1 commit into
Open
Conversation
Owner
|
I'm not sure whether I like this solution. |
Contributor
Author
|
We should look into it. But a provider returning an invalid result also shouldn't crash the app imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what causes it, but this product: https://world.openfoodfacts.org/product/5414807007998/
Has a
nullname according to the client. The API does list it with a name, so I'm not sure what's going on.I suspect its something to do with OpenFoodFacts4Net, since it hasn't been updated in 3 years.
I might look into fixing either forking that library or just creating a solution inside grocy-scanner.
Anyway, a product with a null name shouldn't cause the application to crash, hence this fix.