fix: handle -Sy, -Sp, -Sh edge cases in buildsPackages - #37
Conversation
|
Thank you, please resolve conflicts first. I am sorry for the mismatch. |
fee10e3 to
509daf1
Compare
Thanks! Conflicts resolved and branch rebased — both PRs should be clean now. |
manticore-projects
left a comment
manticore-projects
left a comment
There was a problem hiding this comment.
The functional improvement looks good but you change URLS and packaging, why?
| pkgdesc="LLM-powered pre-build malware scanner for AUR packages" | ||
| arch=('x86_64' 'aarch64') | ||
| url="https://github.com/manticore-projects/aurscan" | ||
| url="https://github.com/musqz/aurscan" |
There was a problem hiding this comment.
we don't. And is wrong. Will clean it. Thanks.
|
|
||
| ### Catch malicious AUR packages *before* they build. | ||
|
|
||
| > **Fork:** [musqz/aurscan](https://github.com/musqz/aurscan) — see [FORK.md](FORK.md) for changes from upstream. |
| @@ -0,0 +1,30 @@ | |||
| # musqz/aurscan — fork notes | |||
|
|
|||
| 'xdg-utils: open mail client for mailing-list reports') | ||
| source=("$pkgname-$pkgver.tar.gz::$url/archive/v$pkgver.tar.gz") | ||
| sha256sums=('SKIP') # replace with the real checksum on release | ||
| sha256sums=('695452b46cfcb8d71ea2acc82fabc2af4ef64fe8d22693e423e422731969a996') |
|
Thanks for your patience — cleaned up the commit, now contains only the relevant fix with no unrelated edits. |
-Sy/-Syy with no targets or -u only refreshes databases, nothing builds. -Sp/--print prints what would be done without building. -Sh shows sync help. All three incorrectly gated in the upstream-merged PR. Tracked with syncYOnly/syncUpgrade/hasTarget so -Syu and -Sy <pkg> still correctly fire the gate. Adds 7 new test cases; go vet + full suite pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
509daf1 to
a8f6cb4
Compare
|
Apologies for the noise. Rebased onto upstream/main — now a single clean commit with only the relevant fix. No packaging, URL, or doc changes. |
Happens to the best and no harm done. |
2 participants
You noted in #27 that
-Sy/-Syy,-Sp/--print, and-Shstill incorrectly gate — this fixes all three.What was wrong
buildsPackageshad no handling for:-y/--refresh: database refresh without-uor package targets doesn't build anything, but was classified as gate=true-p/--print: print mode (outputs URLs, no build) — same-Sh: sync help —honly sethasOp, leavingisSync && !syncQuerytrueChanges
-Sy/-Syy: addedsyncYOnly,syncUpgrade, andhasTargettracking. A database-only refresh (-Sywith no-uand no package args) returns false.-Syuand-Sy firefoxstill gate correctly.-Sp/--print:padded to thesyncQueryshort-flag set;"print"added to the long-opt switch.-Sh:hnow sets bothhasOp=trueandsyncQuery=true, so help in any context is non-building. Bare-hand--helpbehaviour unchanged.Tests
7 new cases in the table-driven suite;
go vet+ full suite pass.