Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds half of #140.
Allows the use of
{manga.year}as a placeholder in path formatting (--path) and filename formatting (--filename-<format>).Also adds the publication year to manga info files (excl. Mihon) and
ComicInfo.xmlfiles. It is not included in the Mihon format, as a "year" key is not defined in their schema. (and I don't know if it would simply be ignored.)Feel free to revert theComicInfo.xmlchanges, since while Kavita implies that only using the year means that the year defines the release date of the series, the official schema states that the all of the year, month, and day, are used as the release date of the book (i.e., volume, chapter -- whatever the.cbzfile contains). (theyearreturned by MangaDex is of the series.) Waiting for confirmation here: anansi-project/comicinfo#18Note: This doesn't yet add year metadata to EPUB files.Edit: Doesn't currently make sense to add publication year to book file metadata.