Breaking: Modernize and improve notification message component - #325
Open
pichfl wants to merge 6 commits into
Open
Breaking: Modernize and improve notification message component#325pichfl wants to merge 6 commits into
pichfl wants to merge 6 commits into
Conversation
pichfl
force-pushed
the
reorganize-dom
branch
3 times, most recently
from
December 15, 2021 16:33
7a158c5 to
0ebc547
Compare
pichfl
marked this pull request as ready for review
December 15, 2021 16:34
pichfl
force-pushed
the
reorganize-dom
branch
from
December 15, 2021 16:53
0ebc547 to
b4cf56a
Compare
pichfl
changed the title
- simplify component class - move @z-index@ handling to CSS custom property Replaces mansona#272
* Better variables * Slightly more readable colors * Support `prefers-reduced-motion` and reduces motion in Ember tests by default * Added proper ARIA role to notification * Partially replaces mansona#250
Much more stable than setTimeout and no longer blocks tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be rebased once #324 / #328 are approved and merged.
animationendDOM event instead of manually creating timersprefers-reduced-motionAlso makes #299 possible