refactor: replace deprecated functions and improve internal typing - #1508
Open
JanneSaukkio wants to merge 5 commits into
Open
refactor: replace deprecated functions and improve internal typing #1508JanneSaukkio wants to merge 5 commits into
JanneSaukkio wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to only make improvements to internal variables and methods while avoiding making changes to the user-facing API. Apart from small fix in
MemoryStorage.getItemand replacement of deprecated methods, no changes have been made to the production code.The amount of TypeScript errors in "strict mode" is reduced by 17% across the whole repository. The strict mode became default in TS6. Below are result of running
npm run tsc -- --noEmit --strictagainst master branch and this PR.