fix: Extract prerelease packages on Windows with --force-local - #315
Merged
jjerphan merged 2 commits intoAug 6, 2026
Merged
Conversation
GNU tar treats drive-letter paths as remote hosts; pass --force-local on win32 so conda-package installs of prereleases succeed. Add a unit test and run the prerelease CI job on Windows and macOS. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
--force-local alone was not enough: GNU tar still mangles backslash paths passed to -C. Extract with cwd + relative archive/dest paths, and normalize any absolute Windows paths to forward slashes. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
marked this pull request as ready for review
August 6, 2026 07:44
Hind-M
reviewed
Aug 6, 2026
Hind-M
left a comment
Member
There was a problem hiding this comment.
Can you point to the job running conda-package.test.ts? I couldn't find it.
Otherwise LGTM.
Member
Author
|
|
Member
|
Yes the |
Hind-M
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #310..
Failures for observed in mamba-org/mamba#4373.
GNU tar treats drive-letter paths as remote hosts; pass --force-local on win32 and extract with cwd + relative archive/dest paths (before normalize any absolute Windows paths to forward slashes) so conda-package installs of prereleases succeed.
Add a unit test and run the prerelease CI job on Windows and macOS.