Skip to content

fix: Extract prerelease packages on Windows with --force-local - #315

Merged
jjerphan merged 2 commits into
mamba-org:mainfrom
jjerphan:fix/windows-prerelease-tar-extract
Aug 6, 2026
Merged

fix: Extract prerelease packages on Windows with --force-local#315
jjerphan merged 2 commits into
mamba-org:mainfrom
jjerphan:fix/windows-prerelease-tar-extract

Conversation

@jjerphan

@jjerphan jjerphan commented Aug 6, 2026

Copy link
Copy Markdown
Member

Follow-up of #310..

Failures for observed in mamba-org/mamba#4373.

GNU tar treats drive-letter paths as remote hosts; pass --force-local on win32 and extract with cwd + relative archive/dest paths (before normalize any absolute Windows paths to forward slashes) so conda-package installs of prereleases succeed.

Add a unit test and run the prerelease CI job on Windows and macOS.

GNU tar treats drive-letter paths as remote hosts; pass --force-local on
win32 so conda-package installs of prereleases succeed. Add a unit test
and run the prerelease CI job on Windows and macOS.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan added the bug Something isn't working label Aug 6, 2026
--force-local alone was not enough: GNU tar still mangles backslash
paths passed to -C. Extract with cwd + relative archive/dest paths, and
normalize any absolute Windows paths to forward slashes.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
jjerphan marked this pull request as ready for review August 6, 2026 07:44
@jjerphan
jjerphan requested a review from pavelzw as a code owner August 6, 2026 07:44

@Hind-M Hind-M left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point to the job running conda-package.test.ts? I couldn't find it.
Otherwise LGTM.

@jjerphan

jjerphan commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

conda-package.test.ts is a unit tests file run inside the Build workflow via pnpm all which now calls tsx --test test/*.test.ts.

@Hind-M

Hind-M commented Aug 6, 2026

Copy link
Copy Markdown
Member

Yes the build workflow is what I was looking for, thanks.

@jjerphan
jjerphan merged commit f457c30 into mamba-org:main Aug 6, 2026
73 checks passed
@jjerphan
jjerphan deleted the fix/windows-prerelease-tar-extract branch August 6, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants