Skip to content

fix: Honor override_virtual_packages configuration - #4364

Open
jjerphan wants to merge 2 commits into
mamba-org:mainfrom
jjerphan:fix/honor-override_virtual_packages-configuration
Open

fix: Honor override_virtual_packages configuration#4364
jjerphan wants to merge 2 commits into
mamba-org:mainfrom
jjerphan:fix/honor-override_virtual_packages-configuration

Conversation

@jjerphan

Copy link
Copy Markdown
Member

Description

Fix #4125.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions Bot added the release::bug_fixes For PRs fixing bugs label Jul 28, 2026
@jjerphan
jjerphan marked this pull request as ready for review July 29, 2026 08:44
@jjerphan
jjerphan force-pushed the fix/honor-override_virtual_packages-configuration branch 3 times, most recently from 5758334 to 477867c Compare July 31, 2026 08:52
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.40%. Comparing base (df10fc2) to head (1860fa9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/core/virtual_packages.cpp 91.66% 3 Missing ⚠️
libmambapy/bindings/legacy.cpp 0.00% 2 Missing ⚠️
libmamba/src/api/info.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4364      +/-   ##
==========================================
+ Coverage   55.38%   55.40%   +0.02%     
==========================================
  Files         243      243              
  Lines       30374    30388      +14     
  Branches     3257     3260       +3     
==========================================
+ Hits        16822    16837      +15     
+ Misses      13549    13548       -1     
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
jjerphan force-pushed the fix/honor-override_virtual_packages-configuration branch from 477867c to 1860fa9 Compare August 4, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Micromamba is ignoring override_virtual_packages specified in .mambarc file

1 participant