Skip to content

fix: Clear stale negative cache entries - #4328

Open
jjerphan wants to merge 7 commits into
mamba-org:mainfrom
jjerphan:fix/clear-negative-cache-entries
Open

fix: Clear stale negative cache entries#4328
jjerphan wants to merge 7 commits into
mamba-org:mainfrom
jjerphan:fix/clear-negative-cache-entries

Conversation

@jjerphan

@jjerphan jjerphan commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Tentative fix for #4322.

Fix failures observed in Code Coverage workflows.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions Bot added the release::bug_fixes For PRs fixing bugs label Jun 22, 2026
@jjerphan jjerphan mentioned this pull request Jun 22, 2026
11 tasks
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.71698% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.26%. Comparing base (df10fc2) to head (ff808f1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/core/transaction.cpp 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4328      +/-   ##
==========================================
+ Coverage   55.38%   56.26%   +0.88%     
==========================================
  Files         243      243              
  Lines       30374    30429      +55     
  Branches     3257     3265       +8     
==========================================
+ Hits        16822    17122     +300     
+ Misses      13549    13304     -245     
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan
jjerphan marked this pull request as ready for review June 22, 2026 11:35
Comment thread libmamba/include/mamba/core/package_fetcher.hpp
Comment thread libmamba/tests/src/core/test_transaction.cpp Outdated
@jjerphan
jjerphan force-pushed the fix/clear-negative-cache-entries branch from 67b4f4c to 1485058 Compare June 22, 2026 16:22
@jjerphan
jjerphan marked this pull request as draft June 23, 2026 09:31
Comment thread libmamba/include/mamba/core/package_fetcher.hpp Outdated
@jjerphan
jjerphan force-pushed the fix/clear-negative-cache-entries branch from fc32cc4 to 1659911 Compare July 1, 2026 11:44
@jjerphan
jjerphan force-pushed the fix/clear-negative-cache-entries branch 2 times, most recently from 173213c to 3bdca20 Compare July 31, 2026 09:13
jjerphan and others added 5 commits August 4, 2026 11:42
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
@jjerphan
jjerphan force-pushed the fix/clear-negative-cache-entries branch from 3bdca20 to 59ca9f6 Compare August 4, 2026 09:43
@jjerphan
jjerphan marked this pull request as ready for review August 4, 2026 13:46
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Comment thread libmamba/tests/src/core/test_transaction.cpp Outdated
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Hind Montassif <hind.montassif@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants