Skip to content

maint: Retry for update - #4220

Merged
jjerphan merged 1 commit into
mamba-org:mainfrom
jjerphan:maint/retry-for-update
Mar 31, 2026
Merged

maint: Retry for update#4220
jjerphan merged 1 commit into
mamba-org:mainfrom
jjerphan:maint/retry-for-update

Conversation

@jjerphan

Copy link
Copy Markdown
Member

Description

Same approach as for the install path to be able to retry in case of failure.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions Bot added the release::maintenance For PRs related to maintenance label Mar 31, 2026
@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.76%. Comparing base (880e0f0) to head (a1b402e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/api/update.cpp 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4220      +/-   ##
==========================================
- Coverage   52.76%   52.76%   -0.01%     
==========================================
  Files         239      239              
  Lines       29264    29275      +11     
  Branches     3106     3107       +1     
==========================================
+ Hits        15442    15446       +4     
- Misses      13819    13826       +7     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
jjerphan force-pushed the maint/retry-for-update branch from 7e82aa2 to a1b402e Compare March 31, 2026 08:27
@jjerphan
jjerphan marked this pull request as ready for review March 31, 2026 08:28
@JohanMabille

Copy link
Copy Markdown
Member

Do you think it can fix the failure in #4201 ?

@jjerphan

Copy link
Copy Markdown
Member Author

Which ones, and how so?

@JohanMabille

Copy link
Copy Markdown
Member

The update failure on OSX.

@jjerphan

Copy link
Copy Markdown
Member Author

Yes, it should help with network issues.

@jjerphan
jjerphan merged commit 115e080 into mamba-org:main Mar 31, 2026
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants