maint: Retry for update - #4220
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
==========================================
- Coverage 52.76% 52.76% -0.01%
==========================================
Files 239 239
Lines 29264 29275 +11
Branches 3106 3107 +1
==========================================
+ Hits 15442 15446 +4
- Misses 13819 13826 +7
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
maint/retry-for-update
branch
from
March 31, 2026 08:27
7e82aa2 to
a1b402e
Compare
jjerphan
marked this pull request as ready for review
March 31, 2026 08:28
11 tasks
JohanMabille
approved these changes
Mar 31, 2026
Member
|
Do you think it can fix the failure in #4201 ? |
Member
Author
|
Which ones, and how so? |
Member
|
The update failure on OSX. |
Member
Author
|
Yes, it should help with network issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same approach as for the install path to be able to retry in case of failure.
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.