review: Suggestions for #4201 - #4213
Closed
jjerphan wants to merge 4 commits into
Closed
Conversation
…cess": false` in JSON output
`TestMultiplePkgCaches::test_no_writable_extracted_dir_corrupted` Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
11 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4213 +/- ##
==========================================
+ Coverage 53.32% 53.42% +0.10%
==========================================
Files 239 239
Lines 29316 29319 +3
Branches 3128 3122 -6
==========================================
+ Hits 15633 15665 +32
+ Misses 13680 13651 -29
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jjerphan
marked this pull request as ready for review
March 26, 2026 19:08
Member
|
Looks like that fix works 🎉 |
Member
Author
|
Feel free to cherry-pick the commit yes. |
Member
Author
|
Closing in preference of #4201. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing suggestions for #4201.
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.