Skip to content

review: Suggestions for #4201 - #4213

Closed
jjerphan wants to merge 4 commits into
mamba-org:mainfrom
jjerphan:json-success-false
Closed

review: Suggestions for #4201#4213
jjerphan wants to merge 4 commits into
mamba-org:mainfrom
jjerphan:json-success-false

Conversation

@jjerphan

Copy link
Copy Markdown
Member

Description

Testing suggestions for #4201.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Klaim and others added 4 commits March 25, 2026 19:24
`TestMultiplePkgCaches::test_no_writable_extracted_dir_corrupted`

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.42%. Comparing base (d392173) to head (4666fdd).

Files with missing lines Patch % Lines
libmamba/include/mamba/core/output.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4213      +/-   ##
==========================================
+ Coverage   53.32%   53.42%   +0.10%     
==========================================
  Files         239      239              
  Lines       29316    29319       +3     
  Branches     3128     3122       -6     
==========================================
+ Hits        15633    15665      +32     
+ Misses      13680    13651      -29     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan
jjerphan marked this pull request as ready for review March 26, 2026 19:08
@Klaim

Klaim commented Mar 27, 2026

Copy link
Copy Markdown
Member

Looks like that fix works 🎉
Should I cherry-pick the commit into #4201 ?
We could also merge both.

@jjerphan

Copy link
Copy Markdown
Member Author

Feel free to cherry-pick the commit yes.

@jjerphan

Copy link
Copy Markdown
Member Author

Closing in preference of #4201.

@jjerphan jjerphan closed this Mar 27, 2026
@jjerphan
jjerphan deleted the json-success-false branch March 27, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants