Remove references to the deleted /agent-notify endpoint - #11
Merged
Conversation
786227c deleted the agent-speech subsystem end-to-end (AgentNotificationKind, the /agent-notify route, agentSpeechMode/Verbosity, and the agent_notify_url status key), but the docs, the plugin demo, and the three project slash commands were never updated to match. The user-visible break: voxclaw-say has no --kind flag, so /voxclaw-summary, /voxclaw-progress and /voxclaw-failure printed usage and exited 2 instead of speaking, and CLAUDE.md and AGENTS.md told every agent to invoke it that way. The status payload also still advertised agent_notify_url in its agent_handoff string, pointing agents at an endpoint that 404s. AgentHandoffPrompt already had a test guarding that string; the hardcoded copy in NetworkSession did not, so extend the status integration test to cover it too. Docs now describe the /read-only architecture the code actually implements. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
786227c("Delete agent-speech subsystem") removed/agent-notify,AgentNotificationKind,agentSpeechMode/Verbosity, and theagent_notify_urlstatus key. The code change was complete; the docs and commands around it were not.What was actually broken for users:
voxclaw-sayhas no--kindflag (correctly removed in913985bfor the /read-only architecture), but.claude/commands/voxclaw-summary.md,voxclaw-progress.mdandvoxclaw-failure.mdall still piped through--kind. All three printed usage and exited 2 instead of speaking.CLAUDE.mdandAGENTS.mdinstructed every agent working in this repo to invokevoxclaw-say --kind summary, so the documented speech convention could never succeed.CLAUDE.mdjustified always emitting via theagentSpeechModesetting, which no longer exists.SKILL.md— served to agents asskill_docin the/statuspayload — documentedPOST /agent-notifywith a requiredkindfield, a{"status":"suppressed"}response, andagent_speech_mode/verbositystatus keys. Agents following it would POST to an endpoint that 404s.GET /statusitself advertisedagent_notify_urlin itsagent_handoffstring, pointing agents at the dead endpoint.The fix
Docs, demo, and slash commands now describe the
/read-only architecture the code implements.README.mdandSKILL.md's 404 row list the routes that actually exist (/read,/ack,/control,/status,/claw). The presentation's "three endpoints" list swaps the dead entry forPOST /ack, which is real.AgentHandoffPromptalready had a test asserting it contains noagent_notify, but the hardcoded duplicate string inNetworkSession.handleStatuswasn't covered — which is exactly how it survived the original cleanup. The status integration test now asserts the same thing about the served payload.docs/refactor-roadmap.mdis left alone: it correctly records the removal as history.Verification
swift buildclean;swift test— 279 tests in 35 suites pass.agent_notify_urlinto the status string makesstatusEndpointReturnsOKfail on!body.contains("agent_notify"), and removing it passes again.grepforagent-notify/agent_notify/--kind/agentSpeech/suppressedacross the repo returns nothing outside the roadmap doc and the tests that assert their absence.🤖 Generated with Claude Code