e2e: scheduled flake gap-filler (default-off)#3968
Draft
nikw9944 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds an hourly
schedule:trigger to thee2eworkflow, guarded by a newGitHub-hosted
schedule-gatejob. The gate returnsproceed=trueonly when thegap-filler is enabled (repo variable
E2E_GAP_FILLER_ENABLED='true'), main has hadno e2e run in 6h (stale), and no e2e run is in flight on any branch (idle).
When it proceeds, the normal
setup+ 4-shard matrix runs onmainHEAD; theresulting run is ingested by the flake-detect system with no changes on its side.
Rationale: the
e2eflake-detection corpus is starved for samples (main fails ~20%of runs, but main runs are infrequent). This tops up samples during genuine lulls
only — the idle condition makes it yield entirely during heavy merge activity, so
it never competes for the constrained concurrent-e2e capacity.
Merges inert: the repo variable is unset by default, so scheduled ticks only run
the lightweight gate and never trigger the matrix. Enable later by setting the
variable. Design + rollout: malbeclabs/infra
docs/plans/2026-07-02-e2e-flake-gap-filler-*.md(tracker malbeclabs/infra#1615).Only
setupneeded changes (aneeds/ifguard); thee2ematrix job alreadygates on
needs.setup.outputs.run-e2e, so a skippedsetupskips the matrix.Testing Verification
actionlint .github/workflows/e2e.ymlpasses clean.node --checkpasses on the gate script's JS constructs.setup.ifevaluates true whenevergithub.event_name != 'schedule'(push/PR/dispatch run exactly as before).e2ejob gates onneeds.setup.outputs.run-e2ewithoutalways(),so
proceed=false(skippedsetup) cleanly skips the matrix.scheduleonly on the default branch); scheduled ticks will run onlyschedule-gateand logproceed=falseuntil enabled.