Skip to content

docs: module dep map follow-ups — circular-dep ROADMAP tracking, CI lint boundary, cross-batch consumer audit, transaction renumbering - #6284

Merged
makr-code merged 18 commits into
developfrom
copilot/themisdb-module-architecture-analysis
Sep 11, 2026
Merged

docs: module dep map follow-ups — circular-dep ROADMAP tracking, CI lint boundary, cross-batch consumer audit, transaction renumbering#6284
makr-code merged 18 commits into
developfrom
copilot/themisdb-module-architecture-analysis

Conversation

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Follow-up to the 72-module dependency documentation pass. Four targeted improvements closing architecture governance gaps identified during that analysis.

Changes

CI Architecture Lint — ingestion → toolbox Boundary Enforcement

  • Added "ingestion": {"toolbox"} to self.prohibited_dependencies in tools/scanners/gs3_step04_design_architecture.py
  • Enforces the one-way contract (toolbox → ingestion; never reverse), documented in src/toolbox/ARCHITECTURE.md and src/ARCHITECTURE.md

ROADMAP.md — Formal Circular Dependency Tracking

  • Added a row to the Critical Release Blockers table: circular dep resolution #5039/#5040 flagged as Wave D / Q1 2027
  • New subsection ### Architecture: Circular Dependency Issues (source-validated 2026-09-09) under ## Known Cross-Module Issues & Limitations:

Cross-Batch Consumer Audit — Batch 4 Downstream Entries

Added missing Batch 4 downstream consumers to six Batch 1–3 upstream tables (29 new rows, 0 deletions):

File Rows added
src/storage/ARCHITECTURE.md +10 (graph, geo, analytics, process, training, document, temporal, tensor, ingestion, content)
src/query/ARCHITECTURE.md +4 (analytics, aql execution, process, content)
src/index/ARCHITECTURE.md +4 (graph, geo, server, content)
src/sharding/ARCHITECTURE.md +3 (distributed_knowledge, distributed_tensor, analytics)
src/llm/ARCHITECTURE.md +4 (training, distributed_tensor, llm_wiki, governance)
src/rag/ARCHITECTURE.md +4 (ethics_ai, llm_wiki, distributed_knowledge, governance)

src/transaction/ARCHITECTURE.md — Section Renumbering

  • Removed stray empty duplicate ## 8. Sourcecode Verification inserted by prior batch agent
  • Renumbered all sections sequentially §1–§10: ## Module Dependencies → §5, ## Integration Points (Detailed) → §6, original §5–§8 shifted to §7–§10

Known Follow-ups

Type of Change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Refactoring (non-breaking)
  • Documentation
  • Breaking change (requires MAJOR version bump — see VERSIONING.md)
  • Security fix
  • Other:

Breaking Change Checklist

  • MAJOR version bump planned in VERSION and CMakeLists.txt
  • Migration guide added in docs/migration/
  • Announcement prepared for GitHub Discussions (≥ 2 weeks before release)
  • CHANGELOG ### Removed / ### Changed section updated

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Benchmarks run (if performance-sensitive change)

Security Tiering Impact (Required for Runtime Changes)

  • Impacted tier(s):

    • N/A (docs-only / non-runtime)
  • Trust-boundary crossings documented in PR description (example: T3 -> T2, T5 -> T4 brokered call)

  • Boundary controls validated for affected T3/T4/T5 paths (AuthN/AuthZ, validation, rate limits, audit)

  • Boundary-focused tests added/updated or explicit N/A rationale provided

  • If trust level/privilege increased, security maintainer approval is attached

📚 Research & Knowledge (wenn applicable)

  • Diese PR basiert auf wissenschaftlichen Paper(s) oder Best Practices?

Relevante Quellen:

  • Paper:
  • Best Practice:
  • Architecture Decision:

AI-Generated Code (KI-generierter Code)

  • Symbol-Referenzen mit GetSymbolReferences_CppTools geprüft
  • Keine rohen Pointer und kein new/delete ohne explizites Review eingeführt
  • RAII und Exception-Safety für neue/angepasste Pfade geprüft
  • Keine unnötig komplexen KI-Abstraktionen eingeführt
  • Performance-Metriken geprüft, falls Hotpath betroffen

AI Review Workflow (Required for AI-assisted PRs)

  • Findings-first review performed with .github/prompts/pr-diff-findings-review.prompt.md
  • Security hardening review performed for security-sensitive/runtime changes with .github/prompts/security-hardening-review.prompt.md (or N/A documented)
  • API impact review performed for API/contract changes with .github/prompts/api-change-impact-review.prompt.md (or N/A documented)
  • All Critical/High findings are resolved or explicitly accepted with rationale in PR description
  • Residual risks and follow-up actions documented in PR description
  • Severity policy applied according to .github/copilot/REVIEW_SEVERITY_POLICY.md

High-Finding Exception Record (only if High is accepted)

  • High-finding exception claimed in this PR

Release Readiness Gate (Required for release-scoped changes)

  • Release readiness reviewed with .github/prompts/release-readiness-check.prompt.md for branch transition scope
  • Branch governance validated against BRANCHING_STRATEGY.md and RELEASE_STRATEGY.md
  • Versioning/changelog impact validated against VERSIONING.md and CHANGELOG.md

Checklist

  • Code follows project style guidelines (clang-format / clang-tidy)
  • Self-review completed
  • Documentation updated (if needed)
  • CHANGELOG.md updated under [Unreleased]
  • No new warnings introduced
  • Security-sensitive paths reviewed by security maintainer (if applicable)

Scanner and IntelliSense Gates

  • IntelliSense/Compiler: no new errors in changed files
  • clang-tidy/cppcheck: no new high-risk findings in changed files
  • Gap Scanner: no new critical findings in categories security, input_validation, query_correctness, distributed_consistency, concurrency, memory
  • Gap Scanner: no new high findings in the same categories (or explicitly approved)
  • Gap Scanner delta report attached (baseline vs current), not only absolute totals
  • New unknown scanner findings triaged (fixed, re-categorized, or justified)

Copilot AI and others added 8 commits September 9, 2026 05:18
…path modules

- src/server/ARCHITECTURE.md: add ## Module Dependencies + ## Integration Points; validated date 2026-09-09
- src/query/ARCHITECTURE.md: add ## 14 Module Dependencies + ## 15 Integration Points; Last Updated 2026-09-09
- src/transaction/ARCHITECTURE.md: add ## Module Dependencies + ## 9 Integration Points (Detailed); Last Updated 2026-09-09
- src/sharding/ARCHITECTURE.md: add ## Module Dependencies + ## Integration Points; validated date 2026-09-09
- src/storage/ARCHITECTURE.md: add ## Module Dependencies + ## Integration Points; validated date 2026-09-09
- src/replication/ARCHITECTURE.md: add ## Module Dependencies + ## Integration Points; validated date 2026-09-09

Upstream dependency tables sourced from confirmed include/src scan (2026-09-09).
Circular deps (llm↔server, query↔llm, sharding↔transaction) documented with contract + thread-safety + failure-mode notes.

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
…g layer

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
- src/llm/ARCHITECTURE.md: add Module Dependencies (15 upstream, 5 downstream),
  Integration Points (5 critical), Known Design Issues (llm↔server circular via
  mcp_tool_bridge.cpp→mcp_server.h; llm↔query bidirectional via lora_functions.cpp;
  distributed-collectives open item); Last Updated → 2026-09-09
- src/rag/ARCHITECTURE.md: add Module Dependencies (11 upstream, 3 downstream),
  Integration Points (5: ContextWindowBudget, ILLMPlugin, IVectorIndex, KnowledgeGraph,
  Recall@k open); Last Updated → 2026-09-09
- src/search/ARCHITECTURE.md: add Last Updated + status header, Module Dependencies
  (5 upstream, 3 downstream), Integration Points (5: HybridSearch v2.0, LlmReranker
  injected, ANNFrontdoor, LayeredRetrievalOrchestrator v3.0, DistributedHybridSearch v2.2);
  Last Updated → 2026-09-09
- src/index/ARCHITECTURE.md: add Last Updated + status header, Module Dependencies
  (6 upstream, 3 downstream), Integration Points (4: IVectorIndex/ISecondaryIndex/
  IGraphIndex contracts, ANNFrontdoor frozen ABI, GPU RAII guards, LoRA adaptation);
  Last Updated → 2026-09-09
- src/acceleration/ARCHITECTURE.md: add Module Dependencies (leaf module, 0 upstream
  ThemisDB deps; 4 downstream consumers), Integration Points (5: ComputeBackend dispatch,
  DeviceManager probing, CUDA RAII guards, Multi-GPU/NCCL-RCCL, Plugin+shader integrity);
  Last Updated → 2026-09-09

SOT domain: module-behavior + architecture-governance
Level: level1 (src/<module>/)
Milestone: DOC-WEEKLY-2026-37

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
…9-09)

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
… modules

Modules updated (26 files this commit; analytics/graph/geo/content/ingestion
already committed in f025b14):

Layer 0/foundation:
- src/utils/ARCHITECTURE.md      — add Module Dependencies + Integration Points
- src/base/ARCHITECTURE.md       — add Module Dependencies + Integration Points

Layer 0+/framework:
- src/core/ARCHITECTURE.md       — Last Updated 2026-09-09; add § Module Dependencies
                                   + expand Integration Points
- src/network/ARCHITECTURE.md    — Last Updated 2026-09-09; add § Module Dependencies
                                   + expand Integration Points
- src/plugins/ARCHITECTURE.md    — add Module Dependencies + Integration Points

Layer 1:
- src/metadata/ARCHITECTURE.md   — add Module Dependencies + Integration Points
- src/temporal/ARCHITECTURE.md   — add Module Dependencies + Integration Points
- src/timeseries/ARCHITECTURE.md — add Module Dependencies + Integration Points
- src/tensor/ARCHITECTURE.md     — add Module Dependencies + Integration Points

Layer 2:
- src/scheduler/ARCHITECTURE.md  — add Module Dependencies + Integration Points
- src/distributed_knowledge/ARCHITECTURE.md — add Module Dependencies + Integration Points
- src/governance/ARCHITECTURE.md — add Module Dependencies + Integration Points

Layer 4:
- src/document/ARCHITECTURE.md   — add Module Dependencies + Integration Points
- src/process/ARCHITECTURE.md    — add Module Dependencies + Integration Points
- src/prompt_engineering/ARCHITECTURE.md — add Module Dependencies + Integration Points

Layer 5:
- src/training/ARCHITECTURE.md           — add Module Dependencies + Integration Points
- src/retrieval/ARCHITECTURE.md          — add Module Dependencies + Integration Points (scaffold note)
- src/ethics_ai/ARCHITECTURE.md          — add Module Dependencies + Integration Points
- src/llm_wiki/ARCHITECTURE.md           — expand Dependencies + Integration Points
- src/distributed_tensor/ARCHITECTURE.md — expand Integration Surfaces + add § Module Dependencies
                                           + Critical Integration blocks

Layer 5 plugins:
- src/whisper/ARCHITECTURE.md        — Last Updated 2026-09-09; add Module Dependencies + Integration Points
- src/stable_diffusion/ARCHITECTURE.md — Last Updated 2026-09-09; add Module Dependencies + Integration Points
- src/llama_cpp/ARCHITECTURE.md      — Last Updated 2026-09-09; add Module Dependencies + Integration Points
- src/onnx_clip/ARCHITECTURE.md      — Last Updated 2026-09-09; expand Integration Points
                                       + add Module Dependencies

Docs-only / no source:
- src/llm_streaming/ARCHITECTURE.md — add Implementation Status (no source)
                                      + Module Dependencies + Integration Points
- src/vector_search/ARCHITECTURE.md — add Implementation Status (no source)
                                      + Module Dependencies + Integration Points

SOT domain: module-behavior / architecture-governance
Level: level1
Milestone: DOC-WEEKLY-2026-37

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
…): transaction ARCHITECTURE.md section renumbering

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
…o Batch 1-3 dep tables

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

This PR is a documentation- and governance-focused follow-up that tightens architecture enforcement (CI lint boundary) and expands module dependency documentation, while also adding formal tracking for known circular dependencies.

Changes:

  • Enforce ingestion → toolbox as a prohibited dependency in the architecture scanner.
  • Add/extend per-module dependency and integration-point sections across many ARCHITECTURE.md files (incl. “docs-only module” disclaimers).
  • Update ROADMAP.md with explicit circular-dependency tracking and a resolution checklist; renumber transaction architecture sections.

Reviewed changes

Copilot reviewed 53 out of 53 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tools/scanners/gs3_step04_design_architecture.py Adds a prohibited dependency to enforce the ingestion/toolbox boundary in CI lint.
ROADMAP.md Adds an explicit circular-dependency blocker row and a detailed tracking subsection.
src/ARCHITECTURE.md Adds a unified dependency map, layers, and documented circular dependencies.
src/whisper/ARCHITECTURE.md Updates “Last Updated” and adds dependency/integration documentation.
src/vector_search/ARCHITECTURE.md Adds “no source implementation” disclaimer plus dependencies/integration notes.
src/utils/ARCHITECTURE.md Adds dependencies and integration points for utils.
src/transaction/ARCHITECTURE.md Renumbers sections and inserts a dependencies + integration section.
src/training/ARCHITECTURE.md Adds dependencies and integration points for training module.
src/toolbox/ARCHITECTURE.md Documents the dependency direction rule and adds dependencies/integration points.
src/timeseries/ARCHITECTURE.md Adds dependencies and integration points for timeseries.
src/tensor/ARCHITECTURE.md Adds dependencies and integration points for tensor.
src/temporal/ARCHITECTURE.md Adds dependencies and integration points for temporal.
src/storage/ARCHITECTURE.md Adds dependency tables and integration points for storage.
src/stable_diffusion/ARCHITECTURE.md Adds dependencies and integration points for stable_diffusion plugin.
src/sharding/ARCHITECTURE.md Adds dependency tables and integration points for sharding.
src/server/ARCHITECTURE.md Adds dependency tables and integration points for server.
src/security/ARCHITECTURE.md Adds dependency tables and integration points for security.
src/search/ARCHITECTURE.md Adds dependency tables and detailed integration-point contracts for search.
src/scheduler/ARCHITECTURE.md Adds dependency tables and integration points for scheduler.
src/retrieval/ARCHITECTURE.md Adds dependencies/integration notes (scaffold/aspirational disclaimer).
src/replication/ARCHITECTURE.md Adds dependencies and integration points for replication.
src/rag/ARCHITECTURE.md Adds dependencies and integration points for RAG.
src/query/ARCHITECTURE.md Adds a dependencies section and new integration points section.
src/prompt_engineering/ARCHITECTURE.md Adds dependencies and integration points for prompt_engineering.
src/process/ARCHITECTURE.md Adds dependencies and integration points for process.
src/plugins/ARCHITECTURE.md Adds dependencies and integration points for plugins.
src/onnx_clip/ARCHITECTURE.md Adds dependencies and integration points for onnx_clip plugin.
src/observability/ARCHITECTURE.md Adds dependencies and integration points for observability.
src/network/ARCHITECTURE.md Adds dependencies and integration points for network.
src/metadata/ARCHITECTURE.md Adds dependencies and integration points for metadata.
src/maintenance/ARCHITECTURE.md Adds dependencies and integration points for maintenance.
src/llm_wiki/ARCHITECTURE.md Adds dependencies and integration points for llm_wiki.
src/llm_streaming/ARCHITECTURE.md Adds “no source implementation” disclaimer plus dependencies/integration notes.
src/llm/ARCHITECTURE.md Adds a module dependency table, integration points, and known circular-dep section.
src/llama_cpp/ARCHITECTURE.md Adds dependencies and integration points for llama_cpp plugin.
src/ingestion/ARCHITECTURE.md Adds dependencies/integration points for ingestion (incl. toolbox mention).
src/index/ARCHITECTURE.md Adds dependency tables and integration points for index.
src/graph/ARCHITECTURE.md Adds dependency tables and integration points for graph.
src/governance/ARCHITECTURE.md Adds dependencies and integration points for governance.
src/geo/ARCHITECTURE.md Adds dependencies and integration points for geo.
src/failover/ARCHITECTURE.md Adds dependencies and integration points for failover.
src/ethics_ai/ARCHITECTURE.md Adds dependencies and integration points for ethics_ai.
src/document/ARCHITECTURE.md Adds dependencies and integration points for document.
src/distributed_tensor/ARCHITECTURE.md Adds dependencies and integration points for distributed_tensor.
src/distributed_knowledge/ARCHITECTURE.md Adds dependencies and integration points for distributed_knowledge.
src/core/ARCHITECTURE.md Adds dependencies and integration points for core.
src/content/ARCHITECTURE.md Adds dependencies and integration points for content.
src/cdc/ARCHITECTURE.md Adds dependencies and integration points for cdc.
src/cache/ARCHITECTURE.md Adds dependencies and integration points for cache.
src/base/ARCHITECTURE.md Adds dependencies and integration points for base.
src/auth/ARCHITECTURE.md Adds dependencies and integration points for auth.
src/analytics/ARCHITECTURE.md Adds dependencies and integration points for analytics.
src/acceleration/ARCHITECTURE.md Documents acceleration as a leaf module; adds dependencies/integration points.
Suppressed comments (2)

src/whisper/ARCHITECTURE.md:1

  • The metadata block previously included **Module Path:** \src/whisper/`but it’s removed in this update. If other module architecture docs rely on this field for consistency/searchability, restore theModule Path` line to avoid losing structured metadata.
    src/stable_diffusion/ARCHITECTURE.md:1
  • The metadata block previously included **Module Path:** \src/stable_diffusion/`but it’s removed in this update. Consider restoringModule Path` to keep module docs consistent and to preserve a stable “where is this module” anchor.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ROADMAP.md Outdated
Comment thread src/ARCHITECTURE.md Outdated
Comment on lines +61 to +67
| **0 — Foundation** | `base`, `core`, `performance`, `utils` | Stateless utilities; no ThemisDB upstream deps |
| **1 — Persistent Storage** | `storage`, `cache`, `metadata`, `timeseries`, `temporal` | RocksDB wrapper, MVCC, blob/columnar, schema management |
| **2 — Distributed Infrastructure** | `sharding`, `replication`, `network`, `transaction`, `cdc`, `failover`, `maintenance` | Consensus (Raft/Paxos/Gossip), WAL shipping, 2PC, ACID, changefeed |
| **3 — Indexing & Search** | `index`, `search`, `geo`, `graph` | HNSW/vector/spatial/graph indexes, BM25+vector hybrid search |
| **4 — Data Processing** | `query`, `aql`, `analytics`, `execution`, `content`, `ingestion`, `toolbox`, `document` | AQL/SQL pipeline, operator execution, multimodal ingestion |
| **5 — AI / LLM** | `llm`, `rag`, `retrieval`, `llm_wiki`, `training`, `prompt_engineering`, `llama_cpp`, `onnx_clip`, `whisper`, `stable_diffusion`, `distributed_knowledge`, `distributed_tensor` | Inference, RAG evaluation, LoRA, embeddings, vision, multi-modal |
| **6 — Application & Protocol** | `server`, `api`, `auth`, `security`, `plugins`, `rpc_grpc`, `acceleration` | HTTP/gRPC servers, 50+ API handlers, GPU acceleration, plugin system |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in edb737043e. I moved acceleration out of the application/protocol layer into its own leaf runtime services layer so the dependency direction matches the module architecture doc.

Comment thread src/ingestion/ARCHITECTURE.md Outdated
Comment thread src/llm/ARCHITECTURE.md Outdated
| observability | `include/observability/` | Inference span telemetry, throughput metrics |
| security | `include/security/` | Prompt sanitisation, credential-isolation at inference boundary |
| utils | `include/utils/` | Common utilities (logging, string helpers) |
| llama_cpp | `stable-diffusion.cpp/` (external) | Underlying llama.cpp inference backend |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in edb737043e. The llama_cpp dependency row now points at the ThemisDB llama_cpp plugin surface instead of the unrelated external path.

@@ -6,8 +6,7 @@
<!-- Links: README.md · ROADMAP.md · FUTURE_ENHANCEMENTS.md -->

**Version:** 1.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in edb737043e. I restored the Module Path metadata line in src/llama_cpp/ARCHITECTURE.md.

@@ -6,8 +6,7 @@
# ONNX CLIP Plugin — Architecture Guide

**Version:** 0.0.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in edb737043e. I restored the Module Path metadata line in src/onnx_clip/ARCHITECTURE.md.

…4 tracking notes

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
…, replication ARCHITECTURE.md

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
…CHITECTURE.md files

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
… execution wiring + ARCHITECTURE.md updates

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
@github-actions github-actions Bot added area:acceleration Acceleration / GPU / CUDA subsystem area:updates Updates subsystem area:plugins Plugin subsystem area:process Process subsystem area:search Search / retrieval / RAG subsystem type:ci CI/CD or build system change type:build Build system or dependency change wave:A Wave A module: access_model, search, sharding, replication, utils, updates, process, audit release_critical Change in a release-critical module; requires sign-off wave:B Wave B module: acceleration, llm, retrieval, tensor, gpu wave:C Wave C module: security, auth, governance wave:D Wave D module: observability, maintenance area:access-model Access model subsystem area:audit Audit / CDC subsystem labels Sep 9, 2026
@github-actions github-actions Bot added status/resolved Finding resolved and verified by automation and removed status/needs-approval Requires explicit maintainer approval before proceeding labels Sep 9, 2026
@makr-code

Copy link
Copy Markdown
Owner

@copilot weiter

…nsumer entries

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot weiter

Source-validated the remaining follow-ups across all three modules:

transaction/ARCHITECTURE.md — added 2 missing downstream consumers (commit e98c7793 → now pushed):

  • api: src/api/themisdb_grpc_service.cpp:18,243,265 — gRPC service wires TransactionManager for explicit begin/commit/rollback RPCs
  • network: src/network/wire_protocol_server.cpp:53,324,2216 — wire-protocol server drives transaction lifecycle for native client connections

cache/ARCHITECTURE.md and replication/ARCHITECTURE.md — tables are already complete. Source scan confirmed no undocumented consumers beyond the five (server, query, llm, sharding, content) and four (server, storage, failover, temporal) already present. No Batch 4 modules (graph, geo, process, training, document, tensor, distributed_knowledge, distributed_tensor, llm_wiki, governance, ethics_ai) include transaction/cache/replication headers directly.

@makr-code

Copy link
Copy Markdown
Owner

@copilot weiter

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot weiter

All work on this PR is complete. The four action_required CI runs are waiting for human approval (bot-authored PRs require maintainer approval to run workflows) — not code issues.

Summary of everything done across this session:

  • cmake fix: THEMIS_EXECUTION_MODULE define deferred past add_library(themis_core) (e98c7793)
  • All four reviewer threads addressed: acceleration layer, llama_cpp row path, llama_cpp/onnx_clip Module Path metadata (edb737043e)
  • transaction/ARCHITECTURE.md: added api and network source-validated downstream consumers
  • cache/ARCHITECTURE.md and replication/ARCHITECTURE.md: source-scan confirmed complete — no missing consumers

@makr-code

Copy link
Copy Markdown
Owner

@copilot weiter

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot weiter

No further work remains on this PR. All code changes are in place (edb737043e, e98c7793, 3c0382d6). The four action_required CI workflows require a maintainer to approve the run — they cannot be unblocked by code changes. The PR is ready for review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:acceleration Acceleration / GPU / CUDA subsystem area:access-model Access model subsystem area:api API / gRPC subsystem area:audit Audit / CDC subsystem area:graph Graph subsystem area:llm LLM / prompt engineering subsystem area:observability Observability / telemetry subsystem area:plugins Plugin subsystem area:process Process subsystem area:replication Replication subsystem area:search Search / retrieval / RAG subsystem area:security Security / auth subsystem area:sharding Sharding subsystem area:storage Storage subsystem area:updates Updates subsystem area:vector Vector search subsystem quality/doc-metadata-failed Markdown metadata governance gate failed on changed documentation files release_critical Change in a release-critical module; requires sign-off status/resolved Finding resolved and verified by automation type:build Build system or dependency change type:ci CI/CD or build system change type:documentation Documentation change type:refactor Code refactoring without functional change wave:A Wave A module: access_model, search, sharding, replication, utils, updates, process, audit wave:B Wave B module: acceleration, llm, retrieval, tensor, gpu wave:C Wave C module: security, auth, governance wave:D Wave D module: observability, maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants