fix: resolve 213 chronic compiler warnings across 14 source files - #6215
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ion, unknown-pragmas, misleading-indentation, unused-functions, missing-field-initializers, sign-compare, type-limits, Wpedantic) Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix chronic build failures based on error report
fix: resolve 213 chronic compiler warnings across 14 source files
Aug 31, 2026
Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
makr-code
marked this pull request as ready for review
August 31, 2026 20:19
github-actions
Bot
added
area:llm
Contributor
|
Target: pr Doxygen Governance Gate
Changed source files
Blocking structural findings
Doxygen warnings
Escalation
source_workflow: Gate: PR Doxygen Governance |
Contributor
✅ Wave C Policy Gate: Edition & License ValidationResult: ✅ Edition & License Validation PASSED Checks
|
Contributor
✅ Wave C Policy Gate: Private Plugin Boundary EnforcementResult: ✅ Private Plugin Boundary Enforcement PASSED Checks
|
Owner
|
fix Copilot wasn't able to review any files in this pull request. 💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs. |
Owner
|
@copilot fix all |
Owner
|
@copilot fix Copilot wasn't able to review any files in this pull request. 💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs. |
- Remove 4 dead functions in voice_assistant.cpp anonymous namespace
- Remove dead detectInjectionAttack in voice_telephony.cpp
- Remove dead communityAttachment in process_community_detector.cpp
- Remove dead calculate_sha256 in model_downloader.cpp
- Fix undeclared draft_model_id -> config_.speculative_draft_model_id in inference_engine_enhanced.cpp
- Add missing AuditLoggerConfig fields splunk_token/siem_ca_bundle_path/secondary_log_path
- Add .index_type = {} and .examples = {} to all FunctionCost/FunctionSignature blocks in tensor_functions.cpp
- Fix DetectionResult bare/partial initializers in knowledge_gap_detector.cpp
- Switch LightRetrievalResult to designated initializers in process_light_retriever.cpp
- Add .index_type = {} to FunctionCost in udf_registry.cpp
- Add missing MULTI_GPU/NPU_*/NNAPI cases to BackendType switch in gpu_memory.cpp
- Replace reinterpret_cast with std::bit_cast in vulkan_kernels.cpp (add #include <bit>)
- Fix graphql.cpp Wparentheses: add parens around && within ||
- Remove always-true live.rowCount >= 0 checks in optimizer_cost_model.cpp
- Remove unused any_circuit_open in distributed_analytics.cpp
- Remove unused queue_end_time in async_inference_engine.cpp
- Remove unused kLLMPrefix in llm_api_handler.cpp
- Remove unused activity_indent in vcc_vpb_importer.cpp
- Remove unused deadline in query_compiler.cpp
- Fix unused stats return value in scheduled_edge_refresh.cpp
- Remove unused start_time in debezium_cdc_importer.cpp
Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Adds .github/skills/code-review/SKILL.md so the Copilot code-review agent can perform context-aware PR reviews in this repository. Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Contributor
Author
Created
Created |
makr-code
approved these changes
Sep 1, 2026
github-actions
Bot
added
area:api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates all chronic (≥3x) compiler warnings aggregated in issue #6096 — 599 total warning occurrences across 14 files, spanning GCC and Clang. Zero behavior changes; purely diagnostic hygiene.
Changes by warning class
-Wunused-resultconfig_file_watcher.cpp:(void)write(...)→[[maybe_unused]] ssize_t rc = write(...)(GCC ignores(void)cast forwarn_unused_resultattrs)-Wformat-truncationrocksdb_wrapper.cpp:snprintfbuf[8]→[12](holds up to 10 decimal digits + null for%06u)timestamp_utils.cpp: ISO-8601 buf[32]→[64]; ms suffix buf[8]→[16]-Wunknown-pragmasvector_index.cpp:#pragma unroll(8)split into#pragma clang loop unroll_count(8)/#pragma GCC unroll 8;#pragma omp simdguarded by#if defined(_OPENMP)-Wmisleading-indentationvector_index.cpp: twoif (...) return X; if (...) return Y;one-liners split to separate lines-Wunused-function(anonymous-namespace helpers, never called in TU)streaming_join.cpp(4 fns),temporal_query_engine.cpp,distributed_transaction_manager.cpp,process_mining.cpp(2 fns),nvme_manager.cpp: annotated[[maybe_unused]]-Wmissing-field-initializersaccess_control.cpp: positionalAuditLoggerConfig{...}→ C++20 designated initializersgraph_index.cpp(2 sites):{edgeId, val}→{.edgeId = ..., .targetPk = ...}tensor_functions.cpp(3 signatures): added.examples = {}and.index_type = {}toFunctionSignature/FunctionCostinitializers-Wsign-compare/-Wtype-limitsinput_validator.cpp: nesting-depth countersint→size_t; removed always-truec >= 0x00guard forunsigned char-Wswitchvoice_session_manager.cpp: added missingCLOSINGcase (→TERMINATEDonly, matching state-machine contract)-Wpedantic(flexible array)nvme_manager.cpp:blk_zone_report::zones[]wrapped with#pragma GCC diagnostic push/pop ignored "-Wpedantic"(kernel ABI struct, must keep C99 FAM layout)Target Version (Required)
Target Version: [Unreleased]
Infrastructure/build-quality fix; no feature or API change.
Description
Bulk remediation of 213 chronic compiler diagnostics (issue #6096). All fixes are strictly diagnostic — no algorithm, API, or data-layout changes except the
CLOSINGswitch case addition which aligns with the existing documented state-machine contract.Linked Issues
Type of Change
Breaking Change Checklist
N/A
Testing
Security Tiering Impact (Required for Runtime Changes)
Impacted tier(s):
Trust-boundary crossings documented in PR description (example: T3 -> T2, T5 -> T4 brokered call)
Boundary controls validated for affected T3/T4/T5 paths (AuthN/AuthZ, validation, rate limits, audit)
Boundary-focused tests added/updated or explicit N/A rationale provided
If trust level/privilege increased, security maintainer approval is attached
📚 Research & Knowledge (wenn applicable)
/docs/research/angelegt?/docs/research/implementation_influence/eingetragen?Relevante Quellen:
AI-Generated Code (KI-generierter Code)
GetSymbolReferences_CppToolsgeprüft (siehe.github/instructions/cpp-language-service-tools.instructions.md)new/deleteohne explizites Review eingeführtAI Review Workflow (Required for AI-assisted PRs)
.github/prompts/pr-diff-findings-review.prompt.md.github/prompts/security-hardening-review.prompt.md(or N/A documented).github/prompts/api-change-impact-review.prompt.md(or N/A documented).github/copilot/REVIEW_SEVERITY_POLICY.mdResidual risks: The
CLOSINGstate-machine case addition invoice_session_manager.cppis low-risk (matches documented contract), but warrants a quick reviewer sanity-check on the transition table.High-Finding Exception Record (only if High is accepted)
High-finding exception claimed in this PR
Finding reference:
Maintainer approver:
Mitigation in current release:
Target fix milestone:
Tracking issue:
Validation evidence:
Release Readiness Gate (Required for release-scoped changes)
.github/prompts/release-readiness-check.prompt.mdfor branch transition scopeBRANCHING_STRATEGY.mdandRELEASE_STRATEGY.mdVERSIONING.mdandCHANGELOG.mdChecklist
[Unreleased]Scanner and IntelliSense Gates
criticalfindings in categoriessecurity,input_validation,query_correctness,distributed_consistency,concurrency,memoryhighfindings in the same categories (or explicitly approved)unknownscanner findings triaged (fixed, re-categorized, or justified)