Skip to content

fix(transaction): correct stale API usage in test_grpc_rpc_adapter breaking develop CI - #6094

Merged
makr-code merged 2 commits into
developfrom
copilot/ci-build-status-tracker-develop
Aug 31, 2026
Merged

fix(transaction): correct stale API usage in test_grpc_rpc_adapter breaking develop CI#6094
makr-code merged 2 commits into
developfrom
copilot/ci-build-status-tracker-develop

Conversation

Copilot AI commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

tests/transaction/test_grpc_rpc_adapter.cpp referenced a type name, field name, and member access pattern that no longer matched the production headers, causing a compile error that broke the develop mainline build.

Changes — tests/transaction/test_grpc_rpc_adapter.cpp

  • Type name: DistributedTransactionManagerConfigDistributedTxnManagerConfig (matches distributed_transaction_manager.h:230)
  • Field name: cfg.wal_pathcfg.wal_directory (matches DistributedTxnManagerConfig struct field)
  • Member access: result.ok() / result.message()result.ok / result.messageDistributedTxnStatus exposes plain data members (bool ok, std::string message), not member functions; 12 call sites fixed

No production code changed. Test logic is identical — only the call sites are corrected to match the current API surface.

Linked Issues

Closes #6075

Type of Change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Refactoring (non-breaking)
  • Documentation
  • Breaking change (requires MAJOR version bump — see VERSIONING.md)
  • Security fix
  • Other:

Breaking Change Checklist

  • MAJOR version bump planned in VERSION and CMakeLists.txt
  • Migration guide added in docs/migration/
  • Announcement prepared for GitHub Discussions (≥ 2 weeks before release)
  • CHANGELOG ### Removed / ### Changed section updated

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Benchmarks run (if performance-sensitive change)

Security Tiering Impact (Required for Runtime Changes)

  • Impacted tier(s):

    • T0 Trusted Core
    • T1 Security & Platform Services
    • T2 Data Plane Engines
    • T3 Interface & Protocol Edge
    • T4 Managed Extension Runtime
    • T5 Plugin Boundary
    • N/A (docs-only / non-runtime)
  • Trust-boundary crossings documented in PR description (example: T3 -> T2, T5 -> T4 brokered call)

  • Boundary controls validated for affected T3/T4/T5 paths (AuthN/AuthZ, validation, rate limits, audit)

  • Boundary-focused tests added/updated or explicit N/A rationale provided

  • If trust level/privilege increased, security maintainer approval is attached

📚 Research & Knowledge (wenn applicable)

  • Diese PR basiert auf wissenschaftlichen Paper(s) oder Best Practices?
    • Falls JA: Research-Dateien in /docs/research/ angelegt?
    • Falls JA: Im Modul-README unter "Wissenschaftliche Grundlagen" verlinkt?
    • Falls JA: In /docs/research/implementation_influence/ eingetragen?

Relevante Quellen:

  • Paper:
  • Best Practice:
  • Architecture Decision:

AI-Generated Code (KI-generierter Code)

  • Symbol-Referenzen mit GetSymbolReferences_CppTools geprüft (siehe .github/instructions/cpp-language-service-tools.instructions.md)
  • Keine rohen Pointer und kein new/delete ohne explizites Review eingeführt
  • RAII und Exception-Safety für neue/angepasste Pfade geprüft
  • Keine unnötig komplexen KI-Abstraktionen eingeführt
  • Performance-Metriken geprüft, falls Hotpath betroffen — N/A (test-only)

AI Review Workflow (Required for AI-assisted PRs)

  • Findings-first review performed with .github/prompts/pr-diff-findings-review.prompt.md
  • Security hardening review performed for security-sensitive/runtime changes with .github/prompts/security-hardening-review.prompt.md (or N/A documented)
  • API impact review performed for API/contract changes with .github/prompts/api-change-impact-review.prompt.md (or N/A documented)
  • All Critical/High findings are resolved or explicitly accepted with rationale in PR description — N/A, test-only fix
  • Residual risks and follow-up actions documented in PR description — none
  • Severity policy applied according to .github/copilot/REVIEW_SEVERITY_POLICY.md

High-Finding Exception Record (only if High is accepted)

  • High-finding exception claimed in this PR

Release Readiness Gate (Required for release-scoped changes)

  • Release readiness reviewed with .github/prompts/release-readiness-check.prompt.md for branch transition scope
  • Branch governance validated against BRANCHING_STRATEGY.md and RELEASE_STRATEGY.md
  • Versioning/changelog impact validated against VERSIONING.md and CHANGELOG.md

Checklist

  • Code follows project style guidelines (clang-format / clang-tidy)
  • Self-review completed
  • Documentation updated (if needed) — N/A
  • CHANGELOG.md updated under [Unreleased] — N/A (test-only)
  • No new warnings introduced
  • Security-sensitive paths reviewed by security maintainer (if applicable) — N/A

Scanner and IntelliSense Gates

  • IntelliSense/Compiler: no new errors in changed files
  • clang-tidy/cppcheck: no new high-risk findings in changed files
  • Gap Scanner: no new critical findings in categories security, input_validation, query_correctness, distributed_consistency, concurrency, memory
  • Gap Scanner: no new high findings in the same categories (or explicitly approved)
  • Gap Scanner delta report attached (baseline vs current), not only absolute totals
  • New unknown scanner findings triaged (fixed, re-categorized, or justified)

Copilot AI self-assigned this Aug 31, 2026
Copilot AI lite review requested due to automatic review settings August 31, 2026 13:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI linked an issue Aug 31, 2026 that may be closed by this pull request
- Replace DistributedTransactionManagerConfig → DistributedTxnManagerConfig
- Replace cfg.wal_path → cfg.wal_directory (correct field name in struct)
- Replace .ok()/.message() function calls → .ok/.message data member access
  (DistributedTxnStatus has plain bool ok and std::string message members)

Fixes CI build failure for run 33384197157.

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build status tracker for develop branch fix(transaction): correct stale API usage in test_grpc_rpc_adapter breaking develop CI Aug 31, 2026
Copilot AI requested a review from makr-code August 31, 2026 13:19
@makr-code
makr-code marked this pull request as ready for review August 31, 2026 14:19
@makr-code
makr-code merged commit 1bab859 into develop Aug 31, 2026
12 checks passed
@github-actions github-actions Bot added this to the Backlog milestone Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Build status tracker — develop

3 participants