feat: Adopt Three.js ui.js as js/gq-ui.js with window.GQUI namespace - #18
Merged
Conversation
Agent-Logs-Url: https://github.com/makr-code/GalaxyQuest/sessions/ebfff0e5-58d0-4aa7-8caa-9038a5a3db1a Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace innerHTML in ui.js from Three.js Editor
feat: Adopt Three.js ui.js as js/gq-ui.js with window.GQUI namespace
Mar 30, 2026
Agent-Logs-Url: https://github.com/makr-code/GalaxyQuest/sessions/b9ca8ed7-f192-4084-9c8b-9f2502957929 Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Replace all innerHTML template-string assignments in ShipyardController with safe DOM construction using document.createElement, GQUI builders, and replaceChildren/createDocumentFragment: - Add gqStatusMsg() helper for single-message status updates - renderSlotProfile → returns DocumentFragment - renderAffinityChips (both versions consolidated) → returns DocumentFragment or null - renderModuleSlotEditor → returns DOM node - updateStatsPreview → uses replaceChildren + GQUI.Div - buildPresetToolbarHtml → buildPresetToolbarDom - refreshPresetToolbar → uses replaceChildren - buildCardsHtml → buildCardsDom - buildBlueprintCardsHtml → buildBlueprintCardsDom - buildHullCatalogHtml → buildHullCatalogDom - buildBlueprintCreatorHtml → buildBlueprintCreatorDom - buildQueueHtml → buildQueueDom - updateBlueprintLayoutOptions → full DOM construction - render() → uses DocumentFragment + replaceChildren - renderDockedVessels → renderDockedVesselsDom (returns DOM node) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
makr-code
marked this pull request as ready for review
March 30, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js/gq-ui.js(GQUI DOM-builder)wm.js– 3 innerHTML → GQUIShipyardControlleringame.js– 15 innerHTML → GQUIgqStatusMsg(el, msg, type)helperrenderSlotProfile()→ DocumentFragmentrenderAffinityChips()merged → DocumentFragment|nullrenderModuleSlotEditor()→ DOM node (GQUI + native select/option)updateStatsPreview()→ GQUI chips + replaceChildrenbuildPresetToolbarHtml()→buildPresetToolbarDom()DOM noderefreshPresetToolbar()→ replaceChildrenupdateBlueprintLayoutOptions()→ replaceChildren + native option elementsbuildCardsDom,buildBlueprintCardsDom,buildHullCatalogDom,buildBlueprintCreatorDom,buildQueueDom)render()→ DocumentFragment + replaceChildrenrenderDockedVessels()→renderDockedVesselsDom()DOM node