fix: send both state and state_id on work item create/update - #184
Open
nowjon wants to merge 1 commit into
Open
Conversation
Self-hosted Plane CE ignores `state` and only applies `state_id`, while Cloud expects `state`. Mirroring both on create/update avoids silent no-ops (makeplane#183). Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughWork item create and update payloads now mirror ChangesWork item state compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_work_item/create_work_itemonly sentstate, which self-hosted Plane CE silently ignores (HTTP 200, state unchanged). Cloud expectsstate; CE expectsstate_id.Context
This is the inverse of community fork fixes that renamed
state_id→statealone (e.g. ZethicTech/plane-mcp-server#13). A single-direction rename breaks the other target; sending both avoids another silent-break cycle.Test plan
uv run pytest tests/test_work_item_state_compat.py -v(5 passed)uv run ruff check/ruff format --checkon touched fileshomelab-ops):PATCHwith{state: <uuid>}only → HTTP 200, state unchangedPATCHwith dual payload from this fix{state: <uuid>, state_id: <uuid>}→ state updatesupdate_work_itemtool path in-process against the same CE instance; tool sent both fields and Plane applied the transition (then reverted for cleanup)mcp__plane__update_work_itemwork on CE