Repository navigation
fix(mobile): 在 iPad 和 iPhone Duo 双栏任务列表顶部显示伙伴 - #7079
Conversation
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The change reaches the mobile home list and its embedded task-list view. 整体可以合并,但建议补上伙伴入口的抽屉关闭流程,避免 Android 用户返回时多按一次。 Findings
Fix with agent prompt### Issue 1
apps/mobile/src/session/HomeSurface.tsx:2979-2985
新增的抽屉伙伴入口绕过了 `runNavigation`。`HomeTeammatesSection` 直接跳转,没有通过 `queueDrawerNavigation` 先关闭并卸载模态抽屉。从 Android 抽屉打开云端伙伴后,原抽屉仍保持打开,其 `BackHandler` 会吞掉第一次系统返回,只关闭背后的抽屉。
建议把伙伴、群聊和创建后的跳转接入抽屉现有的导航回调,避免用户还要再按一次才能离开对话。
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c53c65d56c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1794a2a08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
PR #7079 独立代码审查报告(standard 档)
Findings
Rule coverage — 读取的规则文件及逐项结论
Verification — 实际运行的命令、结果、未执行项及原因均在 PR head 检出的审查 worktree 中运行,保留命令自身退出码:
Intent alignment
Overall — pass0 P0/P1,原意一致性复核通过,无待裁定的核心方向问题。CI 全绿、thread 全部 Resolve、维护者确认门已由 |
这次改了什么
摘要
iPad 和 iPhone Duo 在任务页使用双栏布局时,左侧任务列表没有显示首页顶部的伙伴区。现在内嵌列表同样显示伙伴,并复用首页的展开列表、折叠头像条、搜索与下拉刷新。
伙伴名册的 Provider 从首页路由移到共用的 MobileHome 内,按账号代次重建,确保首页和任务侧栏都有名册且继续遵循页面焦点订阅。
伙伴、云端伙伴、群聊和创建后的前进跳转统一使用列表传入的 guardedPush。模态抽屉先关闭并卸载,再执行最终路由;伙伴选择、账号校验和预览准备仍在卸载前完成,避免返回时多关闭一次遗留抽屉。
关闭开始后,抽屉内容统一停止接收触摸与无障碍操作;退场仍保留原有遮罩,重新打开恢复操作,避免退场中的第二次选择覆盖已排队伙伴的偏好。
变更类型
fix缺陷修复范围
UI 变化
iPhone Duo 展开横屏与 iPad 横屏模拟器已确认左侧伙伴区和右侧聊天同时显示;Duo 同时检查了展开和折叠。使用
--mock模拟数据,截图已在原任务供用户确认,未上传公开附件。模拟群服务的读取提示属于该预览环境,不能作为真实账号群聊链路已验证的证据。docs/design-rules/DESIGN.md§5 Mobile task home teammate section:直接复用 HomeTeammatesSection 的三行预览、显示全部、折叠头像条及语义主题样式;§10:保留既有 Light / Dark 样式,不引入颜色常量。怎么验证的
自动验证
测试价值(unit,PR #7079 抽屉导航反馈):
HomeTeammatesSection.test.tsx:真实组件触发云伙伴、群聊及建群回执;验证宿主延迟路由在关闭前不执行。原有测试仅覆盖名册刷新,未覆盖导航。最小输入为一个伙伴或群条目及延迟 push;新增 3 个用例修复前失败。单独运行 2.07 秒。useTeammateNavigation.test.tsx:真实 hook 的已有伙伴和新建回执均先完成选择,再等待宿主关闭抽屉;卸载后仍能执行已排好的路由。原有用例仅覆盖立即跳转;新增 2 个用例修复前失败。单独运行 1.93 秒。sessionListDrawerUpdates.test.tsx:实际挂载 SessionListDrawer,沿用退场/重开用例检查 RN 原生触摸及无障碍接口;旧覆盖只检查最终卸载,遗漏退场期间第二次伙伴选择。最小输入为 open 从 true 变 false、退出动画尚未完成;两项扩展断言修复前失败,修复后通过。unit、假时钟,单独运行 0.59 秒;最终 100 项定向测试与类型检查均通过。手工验证
iOS Bundled。dash/mobile-split-companions;worktree/Users/dash/Code/Cindy/projects/cindy-src-mobile-split-companions。dash/mobile-split-companions@c335ab98f+9a132eed95,whoami 核对与 Metro 注入一致;未单独展开 DEV build label 截图。未执行的验证
未做真实账号端到端、Android 实机和深色模式目检;本次只调整共用组件挂载,未修改主题样式、远程协议或原生依赖。按风险完成定向验证,未重跑整仓单测。
风险
风险分类
影响与回滚
提交前检查