Repository navigation
refactor(cindy-ping): 统一插件名称与标识 - #198
Conversation
Signed-off-by: liugaowei <liugaowei@xd.com>
🤖 Contributor checklist / 贡献检查清单✅ No missing items detected by this bot. Remaining checks (version bump, tests, packaging) are reported by Verify pull request; maintainers will review. / 本机器人未发现缺失项；版本号、测试、打包由 Verify pull request 报告，维护者会继续 review。 Updated automatically for 92dfc90 (author association: COLLABORATOR). See CONTRIBUTING.md / CONTRIBUTING.zh-CN.md. 本评论自动更新。 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
看过 92dfc90 的改动：纯改名（目录、ID、包名、原生 App 名和 bundle ID、BroadcastChannel、provisioning），没有新增能力、外联或权限，功能代码不变，这部分没问题。 两件事：
|
 [Medium impact] 未发现新增代码缺陷，但仍需维护者人工审查、决定改名检查例外，并完成新版包的实机验证。
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92dfc90331
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "schemaVersion": 3, | ||
| "minCindyVersion": "0.1.114", | ||
| "id": "desktop-emotes", | ||
| "id": "cindy-ping", |
There was a problem hiding this comment.
当这个改名经 .github/workflows/pr-verify.yml 的 Validate official plugin publish contract 步骤检查时，workflow 会设置 BASE_SHA，而 .tests/plugin-contract.test.mjs:469-479 明确要求基线中的 desktop-emotes 目录及其 ID 继续存在；我按该步骤用本提交的父/目标 SHA 运行测试，稳定得到 desktop-emotes: deleting or renaming an official plugin requires an explicit Server migration。因此当前变更的必需发布契约检查必定失败；应先提供可由 gate 验证的显式 Server migration，而不是只新增此 ID。
AGENTS.md reference: AGENTS.md:L66-L67
Useful? React with 👍 / 👎.
Scope
将 Cindy Ping 的插件身份从
desktop-emotes统一为cindy-ping，展示名称保持Cindy Ping，版本提升至0.3.8。范围仅为旧/新插件目录、对应
.tests文件、根双语 README 和provisioning.json：同步目录、manifest ID、npm 包名、原生 App/可执行文件名称、构建与运行路径、设置页通信标识。完成标准是引用一致、可构建打包及原功能回归通过。不改客户端、服务端、仓库校验规则、权限或功能行为，不加入旧身份迁移。What changed / 改了什么
desktop-emotes/→cindy-ping/；四语言展示名均为Cindy Ping。Cindy Ping.app/Contents/MacOS/Cindy Ping，同步 bundle ID、调用路径并重建 arm64/x86_64 程序。Why / 为什么
延续 #196，让目录、插件标识、包名与 Cindy Ping 品牌一致。旧 ID 的版本未获批上线，本次按新身份处理；已有旧 ID 本地安装不会自动迁移。
Checklist
ghost.json只声明实际使用的能力；本次不新增能力。0.3.7提升为0.3.8。minCindyVersion保持0.1.114，未降低或移除。{ "emails": [] }，不自动分发。Tool declaration changes / 工具声明改动
无。
Verification / 验证
codesign --verify --strict通过。.tests/plugin-contract.test.mjs:476的禁止删除/改名断言：desktop-emotes: deleting or renaming an official plugin requires an explicit Server migration。此 PR 保留该规则，预计 Repository-wide gates 因本次有意改名失败，需维护者决定是否接受该例外。${login,,}/${author,,}不支持而失败，Linux CI 核验。BASE_SHA/HEAD_SHA）核对当前包契约通过；该流程不执行上述跨版本改名断言。未触发发布。92dfc903319b472a827ff158f2dfa458171e0dcd，SHA-256eb5f1da25794456766ee932008c0766a9a3921fa288159f70a25bbbe17db0641。这是本地产物，CI 产物以对应 run 为准。Sensitive changes / 敏感变更
插件 ID/目录改名、原生 App 标识及可执行资源重建，需要维护者人工 review。子进程仍通过固定绝对路径和空参数数组启动，不经 shell，无新增参数注入面。既有旧身份本地配置不会自动转入新身份；不修改鉴权、网络、任务能力、最低版本、audience 或审核/发布规则。