Drop jQuery 1.9.1 + Bootstrap 3.3.6 JavaScript (#1288) - #1295
Merged
Conversation
Final step of Track A (#1253). With the navbar (#1290), scrollspy (#1291), citation popover (#1292), and carousel (#1293) all converted to vanilla JS, nothing in the site's frontend uses jQuery or Bootstrap's JS any longer (verified: zero `$(...)` calls, zero Bootstrap data-api attributes besides the inert `data-toggle="popover"` selector). This removes the two now-unused CDN script tags from base.html: - jQuery 1.9.1 (2013; known XSS issues) - Bootstrap 3.3.6 JS Bootstrap's CSS (bootstrap.min.css) stays — only the JavaScript is removed; the grid/CSS migration is the separate Track B. Also tidied a now-stale comment in project-sidebar-sticky.js (the rest of the codebase no longer uses jQuery). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jonfroehlich
added a commit
that referenced
this pull request
Jun 15, 2026
Bumps ML_WEBSITE_VERSION 2.4.0 -> 2.5.0. Marks the completion of Track A (#1288): the frontend is now jQuery-free and Bootstrap-JS-free. Navbar (#1290), citation popover (#1292), and carousels (#1293) rewritten in vanilla JS; dead scrollspy (#1291), jQuery UI, jQuery Easing, and back-to-top removed (#1289/#1290); jQuery 1.9.1 + Bootstrap 3.3.6 JS script tags dropped (#1295). Bootstrap CSS unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capstone of Track A (#1288 / #1253). Removes the jQuery 1.9.1 and Bootstrap 3.3.6
<script>tags frombase.html— they're now unused.Why this is safe now
With the navbar (#1290), scrollspy (#1291), citation popover (#1292), and carousel (#1293) all converted to vanilla JS, nothing in the frontend uses jQuery or Bootstrap JS anymore. Verified on
masterafter those merges:$(...)/jQuerycalls in our JS.$()blocks in any template.data-ride/data-spy/data-slide-to/data-toggle="collapse"/modal/tab/tooltip/dropdown) — the only remainingdata-toggle="popover"is an inert selector for the vanilla popover (Bootstrap popovers have no data-api).base.htmlwas the only template that loaded these libraries.What changes
<script>tags frombase.html.project-sidebar-sticky.js.Bootstrap CSS stays (
bootstrap.min.css) — only the JavaScript is removed. The grid/CSS migration is the separate Track B.Payoff
Verification
All pages return HTTP 200 with no
jquery/bootstrap*.jsin served HTML andbootstrap.min.cssstill present (/,/publications,/awards,/people,/projects,/news, a project page). Each interactive component was verified in-browser in its own PR; this PR is the first time they run with the libraries fully absent, so a final in-browser smoke-check of navbar + citation popover + carousel is worthwhile before merge.Closes #1288. Refs #1253.