fix: use the shadcn scrollbar for the dev UI sidebar - #1824
Merged
Conversation
The template-list ScrollArea had no min-h-0, so as a flex child it grew to its full content height instead of being bounded. Its viewport never scrolled (the custom scrollbar never engaged) and overflow fell through to SidebarContent's overflow-auto, showing the native scrollbar. Add min-h-0 so the ScrollArea is bounded and its shadcn scrollbar is used, matching the preview pane. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe sidebar ChangesSidebar layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dev UI sidebar (template list) showed the native browser scrollbar, unlike the preview pane which uses the shadcn
ScrollAreabar.Cause
The list is wrapped in
<ScrollArea class="flex-1">inside<SidebarContent>, but the ScrollArea has nomin-h-0. A flex child defaults tomin-height: auto, so the ScrollArea grew to its full content height instead of being bounded by the flex container. Its internal viewport therefore never needed to scroll — the custom scrollbar never engaged — and the overflow fell through toSidebarContent(overflow-auto), surfacing the native bar.Fix
Add
min-h-0so the ScrollArea is height-bounded, its viewport scrolls internally, and the shadcn scrollbar is used — matching the preview pane.One-line change, isolated to the dev UI.
Summary by CodeRabbit