Repository navigation
refactor(uvc): move get_avail_uvc out of init_camera_type - #365
Merged
Merged
Conversation
Signed-off-by: Patrick Gehrsitz <github@mryel.de>
There was a problem hiding this comment.
Pull request overview
This PR refactors UVC camera discovery by extracting the /dev/v4l enumeration helper (get_avail_uvc) out of init_camera_type, making the discovery logic reusable and easier to read.
Changes:
- Extracted
get_avail_uvcfrom the local nested function into a dedicatedUVCclass method. - Updated
init_camera_typeto call the extracted helper when building the available UVC camera map.
Suppressed comments (2)
crowsnest/camera/types/uvc.py:117
- Same as above: avoid hard-coding
UVCfor this helper call; useclsfor consistency within a@classmethod.
"by_id": avail_by_id.get(dev_path, None),
}
for dev_path, by_path in UVC.get_avail_uvc("/dev/v4l/by-path").items()
if "usb" in by_path
crowsnest/camera/types/uvc.py:110
init_camera_typeis a@classmethod, but this call hard-codesUVCinstead of usingcls, which makes future renames/subclassing harder (and is inconsistent onceget_avail_uvcis a static/class method).
def init_camera_type(cls) -> Sequence[UVC]:
avail_by_id = UVC.get_avail_uvc("/dev/v4l/by-id/")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meteyou
approved these changes
Aug 2, 2026
Signed-off-by: Patrick Gehrsitz <github@mryel.de>
meteyou
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
get_avail_uvcout ofinit_camera_type.