Route manager exploration - not to be merged here#1
Open
evoactivity wants to merge 21 commits into
Open
Conversation
…aviour in a classic route manager
…ad of [RENDER]() for classic route manager.
…ager - Exclude router_js unit tests from the main test suite via import.meta.glob negation (they test the now-deleted classic paths directly) - Drop resolveViaClassicHooks, runBeforeModelHook, runAfterModelHook from route-info.ts; resolve() now calls resolveViaManager unconditionally - Remove the no-manager else branches in setupContexts (exit and reset loops) in router_js/router.ts - Remove the _routeEnteredOrUpdated classic inner function and its fallback call sites in routeEnteredOrUpdated - Drop the else branch in getRoute that called route._setRouteName directly (ClassicRouteManager.createRoute() handles that now) - Simplify _setOutlets to build RenderState from manager/bucket unconditionally, removing the getRenderState() fallback and the conditional break - Fix _getModel to delegate to routeInfo.getModel() for polymorphic dispatch (handles both URL-param and model-object transitions correctly) - Guard _setOutlets call on shouldRender !== false; add LOG_VIEW_LOOKUPS logging
📊 Package size report 2%↑
Show files (41 files)
🤖 This report was automatically generated by pkg-size-action |
This make outlets and renderer unaware of controllers and models. The Route Manager now curries the invokable with @controller and @model arguments. Model is @Tracked so it rerenders when it changes.
evoactivity
force-pushed
the
route-manager-exploration
branch
from
6d023be to
188c4fe
Compare
….willEnter in InternalRouteInfo
- curries route wrapper args at outlet level
* main: (135 commits) Bump follow-redirects from 1.15.11 to 1.16.0 Set pnpm version Update pnpm/action-setup action to v6.0.6 Update peter-evans/create-pull-request action to v8.1.1 Post-release version bump Add v7.1.0-beta.1 to CHANGELOG for `ember-source` Add v7.0.0 to CHANGELOG for `ember-source` Do not use any caches on publish step. Add deploy environment to require approval by select people before publish to npm. Remove private annotations from helper methods Try new creds Update browserstack infrastructure Update pnpm/action-setup action to v6 Update dependency decorator-transforms to v2.3.2 Update dependency babel-plugin-debug-macros to v1.0.2 Update dependency rollup to v4.60.2 Update dependency qunit-dom to v3.5.1 Update tree-shaken info A couple more Tell rollup to cleanup the dev/prod spit from @glimmer/debug Update pnpm to v10.33.2 ...
📊 Size reportTarball size — dist/dev 2%↑
dist/prod 2%↑
smoke-tests/v2-app-hello-world-template/dist 3%↑
🤖 This report was automatically generated by wyvox/pkg-size |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened just for ease of sharing and reviewing
Right now this is very much in the make it work stage, so linting and types are failing the checks. Will need to be cleaned up but not at this stage.