Skip to content
This repository was archived by the owner on Jan 7, 2020. It is now read-only.

Vulnerability issue fix#411

Open
shankarsengalani wants to merge 1 commit into
maidsafe-archive:masterfrom
shankarsengalani:vulnerability_fix
Open

Vulnerability issue fix#411
shankarsengalani wants to merge 1 commit into
maidsafe-archive:masterfrom
shankarsengalani:vulnerability_fix

Conversation

@shankarsengalani

Copy link
Copy Markdown
Contributor

Removed package-lock.json file to get the vulnerability issue fix from github for a dependency's dependency

@maidsafe-highfive

Copy link
Copy Markdown

r? @ustulation

(maidsafe_highfive has picked a reviewer for you, use r? to override)

@hunterlester hunterlester left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That tutorial is using npm, so either package-lock.json should remain and yarn.lock removed or yarn instructions should replace npm instructions.

hitman401
hitman401 previously approved these changes Jan 8, 2019
@hitman401 hitman401 dismissed their stale review January 8, 2019 06:10

Must update the instructions to use yarn. Also package.json must reflect the same.

@bochaco

bochaco commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

The only reason why I didn't introduce yarn was to keep it simple to starters, so they don't need to install yarn, and also for something like this doesn't need to be that efficient as it doesn't download too many things, so I'd vote for keeping it simpler with just npm.

@bochaco

bochaco commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

I was trying to fix this by forcing the version of the nested dependency webpack-dev-server, and after some trouble I seem to understand how to do it using the command npm ci. However the newer version of webpack-dev-server seems to break backward compatibility and I get the following error when trying to run the app with npm start:

{ Error: Cannot find module 'webpack-dev-server/client'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.resolve (internal/modules/cjs/helpers.js:32:19)
    at config.entry.batch.entry (/home/bochaco/safe/bochaco-safe_examples/safe_web_app_quick_start/node_modules/@neutrinojs/web/index.js:209:43)
...

So it seems we don't have much choice but to wait for a new release of our direct dependencies where they upgrade webpack-dev-server to >=3.1.11. Any other thoughts/ideas?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants