Say how much of the suite CI actually ran, and fail if it shrinks - #7
Merged
Conversation
CI runs on a clean checkout, so tools/.cache is absent and the database tests skip: 93 of them, against 6 when the cache is populated. The workflow reported that as green. It now says what did not run, and fails if the number grows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5, the things that weren't @remmyothman's to fix in a PR that adds CI.
permissions: contents: read. The suite builds nothing and publishes nothing.concurrency, cancelling superseded pull request runs but not pushes to main, so every commit on the default branch keeps its result.tools/.cacheis gitignored, so on a clean checkout 93 tests skip against 6 with the cache populated. CI reported that as green. It now writesRan 713 of 806 tests. 93 skipped, because tools/.cache is absent here.into the job summary, and fails if the number grows.EXPECTED_SKIPSis measured locally with the cache moved aside. This PR is the first run that confirms it against a real clean checkout.