Export the collection as CSV - #3
Open
remmyothman wants to merge 2 commits into
Open
Conversation
- collectionCsv() in collectionview.js builds the CSV, prefixed with a UTF-8 BOM so spreadsheet apps read non-ASCII names (Pokémon, etc.) - Kept pure and DOM-free like the rest of that module, so it is tested - EXPORT AS CSV in the Collection's MORE menu downloads the file - Three tests: BOM, one row per amiibo + header, quote escaping
mahoudeau
requested changes
Aug 19, 2026
mahoudeau
left a comment
mahoudeau
left a comment
Owner
There was a problem hiding this comment.
The shape is right: pure and DOM-free, so it gets tested like the rest of that module. One fix inline and I'll merge. Worth a fourth test with hasDevice: null to pin it.
The download block is the seventh copy of that create-anchor dance in web/js/. Not yours to fix, I'll pull it into a helper right after this lands.
| item.name ?? '', | ||
| item.id ?? '', | ||
| item.hasLocal ? 'yes' : 'no', | ||
| item.hasDevice ? 'yes' : 'no', |
Owner
There was a problem hiding this comment.
hasDevice is three-valued: null means no device has ever been scanned, which is not the same as not being on one, so a fresh visit exports 949 rows claiming On device: no.
Suggested change
| item.hasDevice ? 'yes' : 'no', | |
| item.hasDevice === true ? 'yes' : item.hasDevice === false ? 'no' : '', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds EXPORT AS CSV to the Collection's MORE menu.
collectionCsv()lives incollectionview.js(pure, DOM-free), so it is tested like the rest of that moduleOne concern, one PR — as requested.