Skip to content

Fix silent login startup and explicit Settings access - #24

Merged
mahirozdin merged 1 commit into
mainfrom
t3/review-issue-23-solution
Oct 16, 2026
Merged

mahirozdin merged 1 commit into
mainfrom
t3/review-issue-23-solution

Conversation

@mahirozdin

Copy link
Copy Markdown
Owner

When the menu bar icon is hidden, SmartClose currently opens Settings at every startup, including automatic login launches. This change reads macOS's native login-item Apple Event before deferring UI work: after setup, login launches stay windowless, and explicitly launching or reopening the app opens Settings with either icon preference. Incomplete setup continues to open onboarding.

The presentation decision is independent of menu bar visibility and login registration preferences. Reopening reuses the existing window and restores it if minimized. Sparkle initialization, permission handling, and the monitoring startup path retain their existing behavior.

Adds regression tests, an isolated settings fixture, and a Launch Services smoke test. The smoke test runs outside XCUITest's sandbox so it can pass the app's isolated test environment. README, FAQ, and changelog document the behavior.

Validation on macOS 27.0.1 / Apple Silicon:

  • 68 unit tests and 7 UI tests passed.
  • All 6 native Launch Services launch/reopen scenarios passed: login/manual startup with either icon preference, plus incomplete setup. Checks include initial window counts, activation policy, reuse of the same process, and repeated reopen requests.
  • Debug test build and unsigned Release build passed.
  • git diff --check passed.

The login smoke test delivers the native login Apple Event without logging out. A real logout/login and a full Sparkle update installation remain manual release checks; the smoke test disables monitoring and update checks in its isolated instances.

Closes #23

@mahirozdin
mahirozdin merged commit a76fcc1 into main Oct 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow SmartClose to launch silently without menu bar icon or Settings window

1 participant