Repository navigation
Fix silent login startup and explicit Settings access - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the menu bar icon is hidden, SmartClose currently opens Settings at every startup, including automatic login launches. This change reads macOS's native login-item Apple Event before deferring UI work: after setup, login launches stay windowless, and explicitly launching or reopening the app opens Settings with either icon preference. Incomplete setup continues to open onboarding.
The presentation decision is independent of menu bar visibility and login registration preferences. Reopening reuses the existing window and restores it if minimized. Sparkle initialization, permission handling, and the monitoring startup path retain their existing behavior.
Adds regression tests, an isolated settings fixture, and a Launch Services smoke test. The smoke test runs outside XCUITest's sandbox so it can pass the app's isolated test environment. README, FAQ, and changelog document the behavior.
Validation on macOS 27.0.1 / Apple Silicon:
git diff --checkpassed.The login smoke test delivers the native login Apple Event without logging out. A real logout/login and a full Sparkle update installation remain manual release checks; the smoke test disables monitoring and update checks in its isolated instances.
Closes #23