Repository navigation
fix(conformance): make namespace cleanup failures visible - #65
Merged
Merged
Conversation
magnusp
force-pushed
the
fix/52-namespace-cleanup
branch
2 times, most recently
from
October 21, 2026 22:15
5885b86 to
936cebe
Compare
magnusp
force-pushed
the
fix/52-namespace-cleanup
branch
from
October 21, 2026 22:19
936cebe to
5fd4e07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52. Part of #54.
What changed
XerialTestServer.releaseNamespacenow checks the adminDELETEstatus. Transient responses (I/O, 408, 429, 5xx) are retried up to three times; any non-2xx response other than 404 is surfaced as anIllegalStateException.ensureNamespacerefuses to reuse it. A 409 from namespace create is no longer treated as success, so a stale namespace cannot be silently adopted.connectare attached as suppressed to the primary connection error.NamespaceClosingHandlernow releases onclose,abort, andunwrap(Connection.class).unwrapreturns the proxy so closing the unwrapped handle still releases, and release still runs if the underlying close/abort throws.JSON1Testcloses its per-test connection via@AfterEach; vendoredCachedRowSetTestcloses its connection with try-with-resources.upstream-xerial_sqlite-jdbc.manifestwith the two divergence notes andCHECKSUMS.sha256with the current hashes, using the mechanism from Vendoring checksums and manifest are not enforced #53.tools/export-upstream --verifypasses.Contract decision
Parity with xerial 3.53.4.0 at the pinned tag. The only deviations are the two vendored test edits, which are test-only and required by the Hrana namespace lifecycle: a sqld namespace lives until its last connection closes, so the upstream tests that leak connections would leak namespaces for the whole run.
Evidence
Failing before the fix (original cleanup behavior, with only the test seam in place):
Failures covered failed-delete visibility, retry, 409 reuse, abort release, and unwrap release.
Passing after the fix:
Full verification:
Deviations
The two vendored test edits above are the only deviations from the pinned xerial tag, and both are recorded in
upstream-xerial_sqlite-jdbc.manifestwith updatedCHECKSUMS.sha256current hashes. Runtime behavior is otherwise unchanged.