Repository navigation
fix(conformance): fail fast when the suite is not on libSQL - #59
Merged
Merged
Conversation
magnusp
force-pushed
the
fix/44-conformance-libsql-guard
branch
3 times, most recently
from
October 21, 2026 21:51
3e11146 to
cac0e15
Compare
magnusp
force-pushed
the
fix/44-conformance-libsql-guard
branch
from
October 21, 2026 21:55
cac0e15 to
0184064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
LibsqlConformanceGuard, which opens the suite'sjdbc:sqlite::memory:probe throughDriverManagerand verifies:libSQL JDBC Driver;SQLite (libSQL);alt1source-id marker (SELECT sqlite_source_id()).XerialLauncherSessionListener.launcherSessionOpened, after the conformance shim is registered and before any upstream test can run.LibsqlConformanceGuardTestcovering a valid libSQL connection, a foreign xerial-shaped connection (SQLite JDBC/SQLite), and a non-libSQL server source id.Failure messages name both the resolved and expected values, for example:
Contract decision
No xerial parity question applies. This is harness integrity, so the guard fails closed: if any driver other than the pinned libSQL driver serves the probe URL, or the server is not libSQL, the suite aborts before the first upstream test. Checks use JDBC-visible behavior (
DatabaseMetaDataand a SQL query), not harness internals.Evidence
Failed before the fix (test written first, guard absent):
Passed after the fix:
Fail-fast check: temporarily changing the expected driver name made the same
verifyfail duringlauncherSessionOpened, before any test class ran, with the resolved/expected names above. The temporary edit was reverted and the green run above was repeated afterwards.Deviations
The implementation itself makes no xerial-parity deviation.
Process deviation: this branch is stacked on open PR #28 (
feat/jdbc-xerial-conformance) because the conformance harness referenced by #44 does not exist onmainyet. The PR diff is limited to the three files owned by this issue; retargeting tomainafter #28 merges should leave the same three-file diff.Closes #44