Repository navigation
feat(jdbc): implement savepoints and re-select the xerial SavepointTest - #179
Merged
Merged
Conversation
magnusp
added this pull request to stack #183
October 23, 2026 23:32
magnusp
force-pushed
the
docs/171-conformance-statement
branch
from
October 23, 2026 23:35
16e220d to
562beb3
Compare
magnusp
force-pushed
the
feat/173-savepoints
branch
from
October 23, 2026 23:35
be93f13 to
5a1ab53
Compare
magnusp
removed this pull request from stack #183
October 23, 2026 23:39
magnusp
force-pushed
the
docs/171-conformance-statement
branch
from
October 23, 2026 23:40
562beb3 to
7684661
Compare
magnusp
force-pushed
the
feat/173-savepoints
branch
from
October 23, 2026 23:40
5a1ab53 to
2046088
Compare
magnusp
added a commit
that referenced
this pull request
Oct 24, 2026
…st (#184) ## Why JDBC savepoints were a hard unsupported no-op, and xerial's `SavepointTest` was rejected because of that gap. This is the same change as #179, re-issued on a branch based directly on `main`, because #179 was merged into a stacked base branch instead of `main` and so never reached `main`. ## What changed - Implemented setSavepoint, setSavepoint with a name, rollback, and release over the transaction stream. - Flipped `supportsSavepoints` to true. - Vendored and selected the xerial `SavepointTest`, and added `LibsqlSavepointTest` with 15 tests. ## Scope - Savepoint support and the conformance re-selection. No unrelated JDBC behavior changed. ## Tradeoffs - None. ## Blast Radius - Savepoint code path in the JDBC module, plus one new vendored conformance file. The upstream test opens two connections to one path, and the conformance driver maps a path to one sqld namespace, so it passes with no divergence. ## Verification - `./tools/export-upstream --verify`: verified. - `./mvnw -pl libsql-jdbc -am test`: passed. - The conformance lanes passed on the identical content in #179, with `SavepointTest` 4 of 4 under both the libSQL driver and the xerial control probe. Fixes #173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
JDBC savepoints were a hard unsupported no-op, and xerial's
SavepointTestwas rejected because of that gap.What changed
supportsSavepointsto true.SavepointTest, and addedLibsqlSavepointTestwith 15 tests.Scope
Tradeoffs
Blast Radius
Verification
./tools/export-upstream --verifyand--verify-pinned: verified against the pinned commit../mvnw -pl libsql-jdbc -am test: 366 of 366 passed../mvnw spotless:check: passed.