Repository navigation
test(conformance): select DBMetaDataTest, StatementTest, and PrepStmtTest (#163) - #164
Merged
Merged
Conversation
…Test (#163) Fixes #163 Hrana 3 remains the source of truth for transport, values, metadata, batching, transactions, and error reporting. java.sql defines the JDBC surface. xerial/sqlite-jdbc 3.53.4.0 is the behavioral reference and conformance foundation, never a copy target. Select the three classes at the pinned 3.53.4.0 commit, preserve every existing selected file and divergence, and record one divergence per new copy for the sqld and no-describe cases.
27 of 28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
Hrana 3 is the source of truth for transport, values, metadata, batching, transactions, and error reporting.
java.sqlis the source of truth for the JDBC surface. xerial/sqlite-jdbc 3.53.4.0 is the behavioral reference and conformance foundation, never a copy target.What changed
DBMetaDataTest,StatementTest, andPrepStmtTestinupstream-xerial_sqlite-jdbc.manifest; remove their rejections; add their pinned sources to the vendored tree.TypeMapTeststays rejected.UPSTREAM.mdand record the upstream and current hashes inCHECKSUMS.sha256.# divergence:line for each new copy, covering only the cases Hrana or sqld cannot supply.Red
At the base, with only the mechanical removal of xerial-only references so the copies compile without sqlite-jdbc:
Green
At head
55fc0b34851385a994c2660db1d07f40204ea7d8:Logs are in
/tmp/xerial-parity-i163/.Divergences
DBMetaDataTest: sqld rejectsCREATE TEMP TABLEwithSQL_PARSE_ERROR, socolumnOrderOfgetTablesis skipped on libSQL and left intact for the xerial control run.StatementTest: Hrana sends one statement perStmt, so sqld rejects multi-statement strings withSQL_MANY_STATEMENTS; sqld rejects TEMP tables; and independent Hrana streams letDROPsucceed while a materialized result set is open. Those cases are skipped or asserted per driver. The DATE-millis round trip compares the calendar date on libSQL, and standard JDBCunwrap/closeOnCompletioncalls replace the sqlite-jdbc-only class references.PrepStmtTest: Hrana has no describe request, so parameter types, pre-execution metadata, and pre-execution SQL validation assert the libSQL contract or skip; the reused result set is reassigned after the next execute asjava.sqlrequires; DATE-millis compares the calendar date; the four cases that call sqlite-jdbc's own configuration and error-code classes are dropped.