Repository navigation
fix(jdbc): mark prepared executeQuery result set as requested - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
LibsqlPreparedStatement.executeQuery()now passestruefor the result-set-requested flag, matching theLibsqlStatement.executeQuery()contract from #85.ps.executeQuery(); ps.getResultSet()now throwsResultSet already requested, as sqlite-jdbc does.Three-layer contract. Protocol-neutral: JDBC owns the result-set-requested lifecycle, and Hrana 3 supplies no field for it.
Files.
LibsqlPreparedStatement.javaandLibsqlStatementLifecycleTest.java.Red. At trunk 91ad4c3 with the new case applied:
Tests run: 9, Failures: 1and the prepared case fails ongetResultSet()returning the open result set instead of throwing (/tmp/xerial-parity-i107/lane-1-trunk-red.log).Green. At head 7125986:
Tests run: 9, Failures: 0(/tmp/xerial-parity-i107/lane-1-unit-green.log).Lanes at head 7125986.
ResultSetWithoutResultsTest: 1 test, pass.spotless:check: pass.Perf. Wall clock of
./mvnw -pl libsql-jdbc test, three interleaved runs each. Trunk median 2.10 s, head median 2.08 s, within the 10 percent rule. The first run of each side is cold-cache at 3.11 s and 3.37 s and was excluded by the median.Divergences. None.
Base. 91ad4c3. Head. 7125986.
Logs are under
/tmp/xerial-parity-i107/.