Skip to content

Categorize rejected xerial tests as permanent or addressable #172

Closed

Description

@magnusp

Problem

upstream-xerial_sqlite-jdbc.manifest records every rejected test with a prose reason, but the reasons are not categorized, so it is not obvious which rejections are permanent and which could be reversed. Some rejections are also stale: SavepointTest is rejected as "not implemented", but SQLite SAVEPOINT SQL over Hrana makes it implementable; MathFunctionsTest depends only on the server build enabling SQLITE_ENABLE_MATH_FUNCTIONS.

Proposed change

Add a category tag to each rejected line (for example # permanent: native-api, # permanent: config-surface, # permanent: remote-model, # build-flag, # addressable: savepoints) and correct any rationale that later PRs changed.

Acceptance criteria

  • Every rejected class carries a category.
  • Addressable classes (savepoints, and math functions if the sqld build supports it) are called out distinctly from permanent exclusions.
  • tools/export-upstream --verify still passes after the manifest edit.

Activity

  1. added
    documentationImprovements or additions to documentation
    enhancementNew feature or request
    P2Normal priority: edge case, feature gap, or test/process improvement
    on Oct 23, 2026
  2. magnusp commented on Oct 24, 2026

    @magnusp
    OwnerAuthor

    Implemented in #178, merged to main in fc3f819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal priority: edge case, feature gap, or test/process improvementdocumentationImprovements or additions to documentationenhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions