Escape structural characters in keys when writing - #90
Open
gaoflow wants to merge 1 commit into
Open
Conversation
Write escaped only space and colon in a key, but the lexer also ends a key at '=' and treats a leading '#'/'!' as a comment. Writing such a key therefore did not round-trip: '=' split the key and a leading '#'/'!' dropped the whole line. Escape '=' and a leading '#'/'!' so Load(Write(p)) is identity; the parser already reads the escaped forms. Fixes magiconair#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writeescaped only space and:in a key, but the lexer treats two more characters as structural in a key position (lex.go):=ends a key (isEndOfKey) and a leading#/!starts a comment (isComment). SoLoad(Write(p))was not identity for such keys —=split the key and a leading#/!dropped the whole line.Escaping
=and a leading#/!fixes it; the parser already reads\=,\#,\!. Mid-key#/!are left unescaped since they are only structural at line start (and already parse fine, e.g.key#2in the read tests). The value path is unchanged — none of these are structural after the separator.Added round-trip and exact-output tests covering every special key character in both encodings. Full suite,
gofmtandgo vetpass.Fixes #59