Skip to content

fix: reject empty filename in LoadFile #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sonnemusk wants to merge 1 commit into from
Closed

fix: reject empty filename in LoadFile #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions empty_file_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package properties

import "testing"

func TestLoadFileEmptyPath(t *testing.T) {
if _, err := LoadFile(" ", UTF8); err == nil {
t.Fatal("expected error")
}
if _, err := LoadFile("", UTF8); err == nil {
t.Fatal("expected error")
}
}
4 changes: 4 additions & 0 deletions load.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ func LoadMap(m map[string]string) *Properties {

// LoadFile reads a file into a Properties struct.
func LoadFile(filename string, enc Encoding) (*Properties, error) {
filename = strings.TrimSpace(filename)
if filename == "" {
return nil, fmt.Errorf("properties: empty filename")
}
l := &Loader{Encoding: enc}
return l.LoadAll([]string{filename})
}
Expand Down
Loading