Skip to content

fix(server): v0.5.1 follow-ups — GUI TTL wiring + in-flight-safe sweep, kwargs to TUI/MCP, alias-keyed kwargs#50

Merged
magicnight merged 1 commit into
mainfrom
feat/v0.5.1-finish
Jul 7, 2026
Merged

fix(server): v0.5.1 follow-ups — GUI TTL wiring + in-flight-safe sweep, kwargs to TUI/MCP, alias-keyed kwargs#50
magicnight merged 1 commit into
mainfrom
feat/v0.5.1-finish

Conversation

@magicnight

Copy link
Copy Markdown
Owner

Finishes the v0.5.1 follow-ups flagged in the #49 review.

A4 — per-model idle TTL:

  • Wired into the GUI: EngineCoordinator.load reads ModelParameters.ttlSeconds → ModelPool.load(ttlSeconds:).
  • Fixed the sweepIdle mid-use hazard: PooledEngineEntry.isGenerating in-flight marker; EngineCoordinator.generate marks the entry around the stream (cleared on success/throw/cancel via defer); sweepIdle skips in-flight entries.

A5 — template kwargs:

  • Wired to CLI ChatTUI (interactive) and MCPBridge (both previously dropped kwargs).
  • Server templateKwargs(for:) resolves an alias to the real model id before loading kwargs.

Tests: testSweepIdleSkipsInFlightGeneratingEntry, aliasResolvesToModelWithTemplateKwargs. 173 tests pass; MacMLXCore + CLI + GUI all build clean (independently verified).

…eepIdle; template kwargs to CLI TUI/MCP + alias-keyed server lookup
@magicnight magicnight merged commit 5e461fb into main Jul 7, 2026
@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant