Conversation
|
@codex please review, the basic feature loop is somewhat done, but I think there are quite a few rooms for failure recover and other things for improvement, that part can be postponed for now I think. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01f9c125ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex please do another round of review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc948e3f48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| private fun collectSaveRequests() { | ||
| viewModelScope.launch { |
There was a problem hiding this comment.
When a save is already running, the user edits again, taps Save, and then switches between the iOS search and timetable sections, the second plan remains buffered in this view-model-local channel while teardown cancels the collector. NonCancellable protects only the transaction currently executing; after that transaction returns, the cancelled loop exits without consuming the newer plan, so the latest explicit save is lost. The fresh evidence beyond the earlier comments is that the new conflated queue is still owned by the controller-scoped view model rather than the shared/app-scoped owner; keep the queue and worker alive above the switched controllers or ensure the pending snapshot is drained during teardown.
Useful? React with 👍 / 👎.
… of viewModel ends
1 participant
No description provided.