Adding opentelemetry - #4548
Open
bitbyt3r wants to merge 4 commits into
Open
Conversation
bitbyt3r
marked this pull request as ready for review
March 7, 2026 07:56
kitsuta
approved these changes
Mar 17, 2026
| _unrepr(_config['appconf']) | ||
| c.APPCONF = _config['appconf'].dict() | ||
| c.SENTRY = _config['sentry'].dict() | ||
| c.OTEL = _config.get('otel', {'enabled': False, 'endpoint': 'http://localhost:4317', 'sample_rate': 100}).dict() if hasattr(_config.get('otel'), 'dict') else _config.get('otel', {'enabled': False, 'endpoint': 'http://localhost:4317', 'sample_rate': 100}) |
Member
There was a problem hiding this comment.
Since we're putting defaults in the configspec file, do we need this set of hardcoded defaults?
| XlsxWriter==3.2.5 | ||
| xmlsec==1.3.16 | ||
|
|
||
| opentelemetry-api |
Member
There was a problem hiding this comment.
Should we pin these libraries? I'd hate to get a broken build because our telemetry library had a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds opentelemetry support to ubersystem.
Config:
This requires line of sight to an opentelemetry collector server. When enabled, it pushes:
All of the above are corollated with each other, so you can dig into any web request and see the logs, exceptions, DB queries, etc that it made.