Skip to content

CHANEY BIGFIXES: fix lots of band plugin UI / prereg / UX fixes - #63

Closed
binary1230 wants to merge 8 commits into
masterfrom
chaney-common-origin
Closed

CHANEY BIGFIXES: fix lots of band plugin UI / prereg / UX fixes#63
binary1230 wants to merge 8 commits into
masterfrom
chaney-common-origin

Conversation

@binary1230

@binary1230 binary1230 commented May 16, 2016

Copy link
Copy Markdown
Contributor

WIP, but ready for some review, this is part of a large batch of changes made by @cybersenshi. @cybersenshi wrote all the code (w00t) and Dom helped put the PR together

Must be merged AFTER magfest/ubersystem#1826
Must be merged at the same time as PR magfest-archive/guests#26

Small update of band plugin text for magstock-specific overrides of the band plugin

  • Actual text of the band agreement has changed (for magstock)
  • Lots of small fixes about parking, campground rules, etc

Major band plugin style/graphics/UX overhaul:

  • add new graphics: magstock logo, "purty"-er wood paneling background
  • most of band plugin re-skin completed
  • removed most inline stylesheets
  • added print stylesheet for band agreement, so it looks nice when you hit CTRL+P to print it

Prereg form updates:

  • change base prereg to support better overriding later in plugins
  • needs review from code team
  • prereg workflow needs a test with this stuff in here

Band checklist

  • Note: this overrides all band plugin styling/text with magstock-specific text
  • What we expect is that the changes here will be extracted into the band plugin so that all the events can use them. For now it's just a full override and the underlying band plugin is unchanged

Dom TODO: need to extend only the style changes and not the javascript in the following files:

  • prereg_base.html
  • regform.html
  • ? register_group_member.html

cybersenshi and others added 8 commits May 12, 2016 14:18
- this is part of a large batch of changes
- most of band plugin re-skin completed
- update wood paneling for magstock
- fix checkbox group generate code to provide ID to CSS
- general CSS fixes / updates
- removed most inline stylesheets
- prereg:  change base prereg to support better overriding later in plugins (needs testing with other things)
…ixes

# Conflicts:
#	magstock/static/theme/stockstyle.css
#	magstock/static/theme/stockstyle.css.map
#	magstock/static/theme/stockstyle.scss
#	magstock/templates/bands/index.html
moving chaney's changes into magfest repo from her fork
…y-common-origin

Conflicts:
	magstock/templates/bands/agreement.html

{% block additional_styles %}
<link rel="stylesheet" href="../static/theme/stockstyle.css">
<script src="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.97.6/js/materialize.min.js"></script>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check this in as a static file so uber can work in offline mode

@binary1230

Copy link
Copy Markdown
Contributor Author

hey, sorry for the email traffic, I'm going to delete this PR and re-create it under the correct branch name. everything else will be the same though. sorrrrrrrrrryyyyyyyyyyyyy

@binary1230 binary1230 closed this May 16, 2016
@binary1230
binary1230 deleted the chaney-common-origin branch May 16, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants