add hotel room update timestamps to CSV export - #71
Conversation
|
Question for @bds002: this change will make it so that going forward the last updated timestamp will be displayed in that column. However, when this is deployed, the "last updated" timestamp will be initially the same for all rows, since for existing columns we're just setting it to the current timestamp and then keeping it up to date moving forward. Is this okay? Or do we need to make sure that all of the existing "last updated" timestamps are correct for all of our existing records? |
|
As of this moment. Current time is fine. Everything has been sent to Hotel team for current time. |
|
+1 from me in that case, though I'm mostly just assuming the SQLAlchemy stuff is in line with how we're doing it elsewhere, since that's not something I've taken the time to look into yet. |
|
You may need to put the alembic stuff in the magprime repo, but Vicki is
the expert, I'd ask her.
…On Dec 18, 2016 11:36 PM, "Eli Courtwright" ***@***.***> wrote:
+1 from me in that case, though I'm mostly just assuming the SQLAlchemy
stuff is in line with how we're doing it elsewhere, since that's not
something I've taken the time to look into yet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#71 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFKYyJyk75BbWdNdS0kINGYeaiqch4g1ks5rJgm_gaJpZM4LP_Dv>
.
|
binary1230
left a comment
There was a problem hiding this comment.
+1 from me EXCEPT you may need to move the alembic stuff from here to the magprime repo (we have done the alembic stuff as per-event [i.e. magprime, magstock, etc])
@kitsuta is the alembic expert so I would get her opinion on the placement
|
fixes magfest/ubersystem#2212 |
kitsuta
left a comment
There was a problem hiding this comment.
Oops, when we talked about this in Slack I totally didn't realize that the migration was in the hotel plugin.
DB migrations are 'per event' because they're generally linear (alembic allows non-linear but it's a pain). So we do want to keep migrations out of stuff like the 'hotel' plugin.
I'll copy the relevant stuff to our magprime plugin but all the alembic stuff should be removed in this branch before merging.
This change modified the Room model to add an update timestamp, and modifies the gaylord CSV export to include the update timestamp in the CustomField2 column.