Added Nodelet Support - #8
Open
kmalhan wants to merge 2 commits into
Open
Conversation
magazino
force-pushed
the
indigo-devel
branch
from
November 14, 2016 12:08
46d9718 to
d19986c
Compare
added 2 commits
November 14, 2016 14:48
In order to run as nodelet, manual call of spin function with sleep is replaced by timer callback with separate node handle. Also, node handle is passed by main.cpp and no longer created in pylon_camera_node.cpp
kmalhan
force-pushed
the
nodelet-support
branch
from
November 14, 2016 19:54
89227bd to
66cb03d
Compare
|
+1 |
|
+1 !!! I'm using this PR with a Basler Ace ACA1300-30GC GIGE on ROS kinetic, and it works great! It makes it relatively efficient to run the image_proc debayer nodelet to debayer color images. I'd also be for removing image rectification from the node itself, and launching the main image_proc nodelet. |
ghost
pushed a commit
that referenced
this pull request
Dec 20, 2018
Support for online change of autoflash Approved-by: Uli Klank <uli.klank@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request added functionality to run as nodelet.
In order to run as nodelet, manual call of spin function with sleep is
replaced by timer callback with separate node handle. Also, node handle
is passed by main.cpp and no longer created in pylon_camera_node.cpp
This pull request is tested with Basler daA1600-60uc.
Please review the changes and provide feedback.