Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSV delimiter detection counts commas, semicolons and tabs inside quoted header cells. A semicolon file beginning with
"Name, company, team";Emailis therefore parsed using commas: the header and data collapse into one column, and the email column index and original row cells are wrong.Count only separators outside quoted fields, respecting doubled quotes and preserving the existing delimiter tie-breaking rules. Add the parser coverage requested in #21 and document CSV import behavior in the README.
Fixes #21.
Type of change
Test plan
npm testpasses locally: 26 tests on Node.js 24.22.1.Nine tests call
parseBulkFilewith temporary CSV files. They cover ordinary comma/semicolon/tab files, a BOM, an email in a later column, quoted comma data, four quoted-header regressions (including escaped quotes), and deduplication while retaining original rows and indexes. Four of the nine tests fail against the unchanged implementation; all pass with this fix.node --checkon both JavaScript files andgit diff --checkpass. No manual UI or live SMTP verification was performed; this change is confined to CSV delimiter detection.Checklist
.envfiles committedScreenshots (if UI change)
No UI changes.
Developed and tested with Codex assistance.