Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
public/dashboard.html, both dashboard requests run inside one startup block. When/api/history/statsfailed (or the Chart.js doughnut threw), thecatchshowed the "Failed to load stats" toast and thenreturned. That skipped/api/dashboard/overview, so the unread inbox, running campaigns, suppressed emails and sender accounts stayed as dashes.Change
Removed the
return;from the statscatch. The overview request now runs regardless of the stats outcome. The toast is still shown on a stats failure, and the empty-history path (all zeros) is unchanged.Testing
Added
tests/dashboardOverview.test.js. It extracts the page's inline script, runs it in avmsandbox with a stubbedaxioswhere the stats call rejects and the overview call resolves, and asserts the overview counts are filled.node --test tests/dashboardOverview.test.js: fails on the unfixed code (overview must still fill cmdUnread when stats fails), passes after the change.npm test: 18 of 18 tests pass.Regression test: fails on base twice (/overview must still fill cmdUnread when stats fails/), passes on fix twice (
node --test tests/dashboardOverview.test.js)Fixes #22