fix: correct events schema and clients default limit - #21
Merged
Merged
Conversation
- Fix EventActorType enum: "client" → "clientUser" to match actual API values - Make actorType required in EventCreateRequest with discriminated union: actorType "clientUser" requires companyId, "internalUser" does not - Fix clients listAll default limit: 50000 → 5000 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vp check/test requires Node.js to load vite.config.ts — Bun alone is not sufficient. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventActorTypeenum value from"client"to"clientUser"to match actual APIactorTyperequired inEventCreateRequestusing a discriminated union —"clientUser"requirescompanyId,"internalUser"does notclients.listAll()default limit from 50,000 to 5,000Test plan
EventCreateRequestenforcescompanyIdwhenactorTypeis"clientUser"EventCreateRequestallows omittingcompanyIdwhenactorTypeis"internalUser"clients.listAll()uses 5,000 as default limit🤖 Generated with Claude Code